Skip to content

Conversation

@jazairi
Copy link
Contributor

@jazairi jazairi commented Mar 27, 2023

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

YES

@mitlib mitlib temporarily deployed to timdex-ui-pi-update-dep-hgqj3i March 27, 2023 20:01 Inactive
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4536071406

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.429%

Totals Coverage Status
Change from base Build 4255755495: 0.0%
Covered Lines: 348
Relevant Lines: 350

💛 - Coveralls

@jazairi jazairi merged commit 3f81a44 into main Mar 27, 2023
@jazairi jazairi deleted the update-dependencies branch March 27, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants