Skip to content

Conversation

@matt-bernhardt
Copy link
Member

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

YES

@mitlib mitlib temporarily deployed to timdex-ui-pi-dep-update-ytzrfm April 28, 2023 21:40 Inactive
@github-actions
Copy link

github-actions bot commented Apr 28, 2023

Pull Request Test Coverage Report for Build 5049659875

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.429%

Totals Coverage Status
Change from base Build 4601380232: 0.0%
Covered Lines: 348
Relevant Lines: 350

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-dep-update-g6zmwb May 22, 2023 19:28 Inactive
@JPrevost JPrevost merged commit 39d3b54 into main May 22, 2023
@JPrevost JPrevost deleted the dep-updates branch May 22, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants