Updates returned order of aggregations #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why are these changes being introduced: * The order was rather arbitrary to begin with, and we decided to make the order match at least one real world use case, which is our own DISCO UI Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/DISCO-221 How does this address that need: * This returns the aggregations in the order our DISCO UI currently desires. Future changes to the display order in any UI should probably be handled in the UI itself, but since the initial order was not for a specific purpose this was both easier and fine.
jazairi
approved these changes
Jan 8, 2021
Contributor
jazairi
left a comment
jazairi
left a comment
There was a problem hiding this comment.
Confirmed that TIMDEX returns aggregations in the desired order. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes being introduced:
the order match at least one real world use case, which is our own
DISCO UI
Relevant ticket(s):
How does this address that need:
desires. Future changes to the display order in any UI should probably
be handled in the UI itself, but since the initial order was not for a
specific purpose this was both easier and fine.
Requires Database Migrations?
NO
Includes new or updated dependencies?
YES