TIMX 345 - Add CLI command init-job #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
This PR introduces the first real CLI command
init-jobthat is used to initialize a new job:job-directoryargument to know where to create new jobcore.init_jobfunction to create new jobcore.build_ab_imagesto create new images based on A/B commit SHAsHow can a reviewer manually see the effects of these changes?
pipenv run abdiff --verbose init-job \ -d output/hello-world \ -m "Hello World" \ -a 395e612f8887b279ccf35363694bafb06ef9a25a \ -b 1910426fbcc98e098de222ccdcce3cf3ac1337e7This should:
output/hello-worlddocker images | grep "transmogrifier-hello-world"job.jsonRe-running the command without any modification should return:
Error: Job directory already exists: 'output/hello-world', cannot create new job.Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Code Reviewer(s)