Conversation
Why these changes are being introduced: The timdex-dataset-api (TDA) library recently had a major version bump to account for a refactor that puts Records and Embeddings on more equal footing. This resulted in records read methods moving from TIMDEXDataset to TIMDEXDataset.records. Additionally, the dataset was minorly restructured physically and logically, requiring a metadata rebuild. How this addresses that need: * Updates to TDA v5 * Writing records to dataset now uses td.records.write() vs td.write() Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/USE-530
ehanson8
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Why these changes are being introduced:
The timdex-dataset-api (TDA) library recently had a major version bump to account for a refactor that puts Records and Embeddings on more equal footing. This resulted in records read methods moving from TIMDEXDataset to TIMDEXDataset.records. Additionally, the dataset was minorly restructured physically and logically, requiring a metadata rebuild.
How this addresses that need:
How can a reviewer manually see the effects of these changes?
Please see this Dev1 successful StepFunction run which exercises all applications using TDA v5.
Includes new or updated dependencies?
YES
Changes expectations for external applications?
NO
What are the relevant tickets?
Code review