Skip to content
This repository was archived by the owner on Apr 14, 2023. It is now read-only.

Conversation

@gravesm
Copy link

@gravesm gravesm commented Oct 11, 2019

This is an initial attempt at setting up Github Actions. It's not
optimal, but it does the job until I can figure out better ways to do
things. The biggest issue is that I think the tests workflow should
probably be turned into an action since it's reused in both the test and
deploy workflows.

On push the usual CI jobs will run. On merging into master the CI jobs
will run and then, if successful, a new image for the workflow container
will be built and deployed. The staging Airflow cluster will be
redeployed with the new image.

How can a reviewer see these changes?

Marvel at the Actions tab on the repo.

Reviewer Checklist

  • The commit message is clear and follows our guidelines
  • There are tests covering any new functionality
  • The documentation has been updated if necessary
  • The changes, if applicable, have been verified

This is an initial attempt at setting up Github Actions. It's not
optimal, but it does the job until I can figure out better ways to do
things. The biggest issue is that I think the tests workflow should
probably be turned into an action since it's reused in both the test and
deploy workflows.

On push the usual CI jobs will run. On merging into master the CI jobs
will run and then, if successful, a new image for the workflow container
will be built and deployed. The staging Airflow cluster will be
redeployed with the new image.
Copy link
Member

@JPrevost JPrevost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds GitHub Actions but does not remove the Travis CI stuff. I approved with the assumption you'll pull that out soon in a separate PR.

matrix:
tox: [flake8, safety, py37, coveralls]
steps:
- uses: actions/checkout@master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we want to checkout master here? I'm still unclear on the configs so I may be missing things, but it feels like this would always checkout the master branch even on push to another branch?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it looks like I'm checking out the master branch, but that's not what's happening. What that line does is use the master branch of the checkout action. It will checkout whatever version of the codebase triggered the workflow. There's a little more info here: https://github.com/actions/checkout#usage.

matrix:
tox: [flake8, safety, py37, coveralls]
steps:
- uses: actions/checkout@master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here as the other... not sure if I don't understand or if this should be modified.

@gravesm
Copy link
Author

gravesm commented Oct 15, 2019

I debated removing the travis config on this PR. I think I'm inclined to leave it in for another PR or two to make sure the actions are doing what I think they're doing. But yeah, my plan is to get rid of travis.

@gravesm gravesm merged commit a20d9dc into master Oct 15, 2019
@gravesm gravesm deleted the github-actions branch October 15, 2019 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants