Reworked utility functions and significant regression tests#8
Merged
Conversation
ml-evs
force-pushed
the
ml-evs/refactoring
branch
from
29f05c9 to
e10a1ac
Compare
8 tasks
ml-evs
changed the title
ml-evs
force-pushed
the
ml-evs/refactoring
branch
from
ba2f4e5 to
628f34c
Compare
ml-evs
force-pushed
the
ml-evs/refactoring
branch
from
628f34c to
efbb641
Compare
MJCliffe
approved these changes
Aug 23, 2023
Owner
MJCliffe
left a comment
MJCliffe
left a comment
There was a problem hiding this comment.
Thanks, looks great! Didn't know Greek was allowed. Once the utils.py is finished I'll go through expanding on the function description comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves all util code into a utils module, and refactors it with type hints, fewer loops and more pythonic variable names (including some greek... can decide if this is actually a good idea 😅) and function names. Where possible, functions are tested against their legacy versions for consistency.