Fix broken dependencies and deprecated APIs in Classification Transfo…#194
Open
Ganglet wants to merge 1 commit intoML4SCI:mainfrom
Open
Fix broken dependencies and deprecated APIs in Classification Transfo…#194Ganglet wants to merge 1 commit intoML4SCI:mainfrom
Ganglet wants to merge 1 commit intoML4SCI:mainfrom
Conversation
…rmers Fixes ML4SCI#191: - Add requirements.txt with pinned dependencies - Fix torchmetrics calls to include task='multiclass' - Replace deprecated torch.has_mps with torch.backends.mps.is_built() - Remove verbose= param from CosineAnnealingWarmRestarts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #191
What this PR does
Fixes 4 issues that prevent new contributors from running the Classification
Transformers project out of the box.
Changes
1. Added
requirements.txtNo dependency file existed. Running
train.pycrashes with sequentialModuleNotFoundErrorfor wandb, einops, timm, torchmetrics. Addedrequirements.txtwith minimum version bounds for all 9 dependencies.2. Fixed broken torchmetrics API (eval.py:59-61)
torchmetrics>= 0.11 requirestask=argument. Addedtask="multiclass"to
accuracy_fnandauroc_fncalls.3. Fixed deprecated
torch.has_mps(utils.py:32)Replaced with
torch.backends.mps.is_built().4. Removed
verbose=Truefrom CosineAnnealingWarmRestarts (train.py)verboseparameter was removed in newer PyTorch versions. Using--decay_lrflag crashed with
TypeError.Testing
pip install -r requirements.txtinstalls all dependencies cleanlytrain.py --helpruns without errors