Refactor config items that belong in layouts #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ty-porter
force-pushed
the
refactor-config
branch
from
90c8de1 to
8bf52c4
Compare
ty-porter
force-pushed
the
refactor-config
branch
from
ee8cbf2 to
e39dba4
Compare
Fix coord keypath name Fix wordy config setting Update README Change how the delay buffer setting works, update README Change how the delay buffer setting works, update README Clarify line score Revert some old README fixes Fix bad merge Remove unused constant
ty-porter
force-pushed
the
refactor-config
branch
from
858ac46 to
541c790
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change and requires a major version update.
We have a config validator that will prevent old configs from completely bombing, but writing these as deprecations (such as #427 and #602) will take a long time and increase the code complexity, I prefer to just rip the bandaid off with a major version bump in this case
Changelog
config.jsonpregame_weathermoved to weather section (weather.pregame)full_team_names(moved to coordinates)short_team_names_for_runs_hits(moved to coordinates)preferred_game_delay_multipliertosync_delay_secondsand significantly altered its functionalitycoordinates/wXhY.jsonteams.name.fullbooleanfull_team_namesfromconfig.jsonteams.name.shorten_on_high_line_scorebooleanshort_team_names_for_runs_hitsfromconfig.jsonteams.runssection toteams.line_scoreteams.runs.runs_hits_errorssubkeys to theteams.line_scoresectionteams.runs.runs_hits_errors.compress_digitsis nowteams.line_score.compress_digitsteams.runs.runs_hits_errors.showtoteams.line_score.show_hits_and_errors