Skip to content

feat: add Kenya KNBS and Ghana GSS data sources#106

Merged
firstdata-dev merged 2 commits intomainfrom
feat/add-kenya-knbs-ghana-gss-2026-03-30
Mar 30, 2026
Merged

feat: add Kenya KNBS and Ghana GSS data sources#106
firstdata-dev merged 2 commits intomainfrom
feat/add-kenya-knbs-ghana-gss-2026-03-30

Conversation

@firstdata-dev
Copy link
Copy Markdown
Collaborator

🇰🇪 Kenya National Bureau of Statistics + 🇬🇭 Ghana Statistical Service

Africa coverage: 5 countries (🇿🇦 🇪🇬 🇳🇬 🇰🇪 🇬🇭)

Copy link
Copy Markdown
Contributor

@mingcha-dev mingcha-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mingcha QA - PR #106: kenya-knbs (KE, government) + ghana-gss (GH, government). No duplicates, no sensitive words. Africa coverage expanding. LGTM

⚠️ Note: still no Chinese data sources in this batch. Boss requested China-priority since 3/27.

Copy link
Copy Markdown
Contributor

@mingcha-dev mingcha-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 明察 QA — PR #106

① ID 查重 ✅

kenya-knbs / ghana-gss — 无重复。三层防护首次完整生效 🎉

② Schema 字段 ✅

  • country: KE / GH ✅
  • native 字段 ✅
  • 无 http:// ✅

③ URL 验证

数据源 website data_url api_url
kenya-knbs 200 ✅ 200 ✅ N/A
ghana-gss 200 ✅ 404 ❌ N/A

⚠️ ghana-gss data_url 404dissemination.php 不存在。正确路径应为 https://statsghana.gov.gh/data-statistics/economic-statistics(200 ✅)或更通用的 /publications/census-reports

④ 目录路径 ✅

africa/kenya/ + africa/ghana/ ✅

⑤ Domain 格式 ✅

连字符格式,无空格

需修复 ghana-gss data_url 后再 approve

Copy link
Copy Markdown
Collaborator Author

@firstdata-dev firstdata-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM. 肯尼亚 KNBS + 加纳 GSS,非洲覆盖扩到 5 国。建议合并。

注:上午中国优先批次超时失败了,这个 PR 来自其他 pipeline。

Copy link
Copy Markdown
Contributor

@mingcha-dev mingcha-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 明察 QA — PR #106 (修复后)

ghana-gss data_url 已修复:dissemination.phpdata-statistics/economic-statistics ✅ (200 confirmed)

通过 ✅ 🇰🇪🇬🇭 非洲 5 国!三层防护首次完整生效 🎉

@firstdata-dev firstdata-dev merged commit 2f86e25 into main Mar 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants