Open
Conversation
mingcha-dev
requested changes
Apr 25, 2026
Collaborator
mingcha-dev
left a comment
There was a problem hiding this comment.
mingcha-dev
requested changes
Apr 25, 2026
Collaborator
mingcha-dev
left a comment
There was a problem hiding this comment.
mingcha-dev
requested changes
Apr 25, 2026
Collaborator
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA Review — PR #178 — REQUEST CHANGES
❌ 问题 1:china-shenzhen-housing 与 PR #175 重复
PR #175 已包含 firstdata/sources/china/construction/china-shenzhen-housing.json(同 ID、同路径)。请移除。
https://www.landchina.com 返回 HTTP 418(华为云 WAF 拦截 bot),网站实际可能可用但无法自动验证。建议在 notes 中标注 WAF 限制。
其他 3 个源检查通过:
| Check | china-shenzhen-open-data | china-landchina | china-bankruptcy-court |
|---|---|---|---|
| ID dedup | ✅ | ✅ | ✅ |
| Domain dedup | ✅ | ✅ | ✅ |
| URL reachability | 200 ✅ | 418 |
200 ✅ |
| Org-website match | ✅ 深圳市政府数据开放平台 | ✅ 全国企业破产重整案件信息网 | |
| Domain format | ✅ | ✅ | ✅ |
| Prompt injection | Clean ✅ | Clean ✅ | Clean ✅ |
Required:移除 china-shenzhen-housing 后再审。
13291a4 to
e1e1ba9
Compare
mingcha-dev
approved these changes
Apr 25, 2026
Collaborator
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA Review — PR #178 APPROVED ✅
china-shenzhen-housing 重复源已移除。3 个数据源通过:
| Check | china-shenzhen-open-data | china-landchina | china-bankruptcy-court |
|---|---|---|---|
| ID dedup | ✅ | ✅ | ✅ |
| Domain dedup | ✅ | ✅ | ✅ |
| URL | 200 ✅ | 418 |
200 ✅ |
| Org match | ✅ 深圳市政府数据开放平台 | ✅ 全国企业破产重整案件信息网 | |
| Domain format | ✅ | ✅ | ✅ |
| Injection scan | Clean ✅ | Clean ✅ | Clean ✅ |
Note: landchina.com 被华为云 WAF 拦截(418),网站实际可用但 bot 不可达。
New Chinese government data sources identified from MCP user query analysis: - china-shenzhen-open-data: Shenzhen Open Data Platform (深圳市政府数据开放平台) - china-landchina: China Land Market Network (中国土地市场网) - china-bankruptcy-court: National Enterprise Bankruptcy Case Info Network (全国企业破产重整案件信息网) - china-shenzhen-housing: Shenzhen Housing and Construction Bureau (深圳市住房和建设局)
e1e1ba9 to
d6cb881
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Data Sources
4 new Chinese government data sources identified from MCP user query analysis (Langfuse Insight pipeline, 2026-04-24):
china-shenzhen-open-datachina-landchinachina-bankruptcy-courtchina-shenzhen-housingSelection Criteria
make check+make check-ids)Validation
make check: ✅ All 544 files validmake check-ids: ✅ All IDs uniquenativefield in name objects