feat: add 5 China authoritative data sources (PM batch 2026-04-27)#184
Merged
mingcha-dev merged 2 commits intoApr 28, 2026
Merged
Conversation
- china-cppcc: 中国人民政治协商会议 (CPPCC) - governance advisory body - china-nsoas: 国家卫星海洋应用中心 (NSOAS) - satellite ocean data - china-ncsc: 国家应对气候变化战略研究和国际合作中心 (NCSC) - climate strategy - china-casm: 中国测绘科学研究院 (CASM) - surveying and mapping research - china-natesc: 全国农业技术推广服务中心 (NATESC) - agro-tech extension
mingcha-dev
requested changes
Apr 28, 2026
Collaborator
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA Review — PR #184 CHANGES REQUESTED
| Check | china-natesc | china-cppcc | china-casm | china-ncsc | china-nsoas |
|---|---|---|---|---|---|
| ID dedup | ✅ | ✅ | ✅ | ✅ | ✅ |
| Domain dedup | ✅ | ✅ | ✅ | ✅ | ✅ |
| URL | 200 ✅ | 200 ✅ | 200 ✅ | 200 ✅ | 200 ✅ |
| Domain format | ✅ | ✅ | ✅ | ✅ | ✅ |
Issues:
⚠️ natesc.org.cn支持 HTTPS（测试返回 200）→ 请升级为 https- ✅ cppcc.gov.cn / ncsc.org.cn / nsoas.org.cn HTTP-only 已确认（HTTPS 返回 000）
- ✅ casm.ac.cn 已使用 HTTPS
mingcha-dev
requested changes
Apr 28, 2026
Collaborator
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
明察 QA Review — PR #184
✅ 通过项
- 保密检查 ✅
- ID 去重 5/5 ✅（含跨 PR 检查）
- 域名去重 5/5 ✅
- URL 可达 5/5 ✅（全部 200）
- Domains 格式 5/5 ✅（全部 kebab-case）
- Schema 必填字段 ✅
⚠️ 需修改
1. Tags 格式：5 个源全部含中文 tags + 空格 tags，需要：
- 移除所有中文 tags
- 空格改连字符（如
remote sensing→remote-sensing）
2. HTTPS 升级：
china-natesc：https://www.natesc.org.cn→ 200，请升级china-cppcc/china-ncsc/china-nsoas：HTTPS 不通（000），保持 HTTP
改完 tags 和 natesc HTTPS 即可 merge。
mingcha-dev
approved these changes
Apr 28, 2026
Collaborator
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 Re-review — PR #184 APPROVED ✅ 修复验证通过。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
新增5个中国权威数据源（下午批次）
数据源列表
china-cppccchina-nsoaschina-ncscchina-casmchina-natesc验证情况
make check全部通过（545条记录，无重复ID，域名一致性通过）