feat: add 5 China authoritative data sources (PM batch 2026-04-28)#187
Merged
mingcha-dev merged 2 commits intoApr 28, 2026
Merged
Conversation
- china-ccs: China Classification Society (中国船级社) - maritime classification - china-caupd: China Academy of Urban Planning and Design (中国城市规划设计研究院) - china-agri: China Agricultural and Rural Information Network (中国农业农村信息网) - china-nsii: National Specimen Information Infrastructure (中国国家标本资源平台) - china-sae: Society of Automotive Engineers of China (中国汽车工程学会)
mingcha-dev
requested changes
Apr 28, 2026
Collaborator
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA Review — PR #187 CHANGES REQUESTED
| Check | china-caupd | china-agri | china-ccs | china-nsii | china-sae |
|---|---|---|---|---|---|
| ID dedup | ✅ | ✅ | ✅ | ✅ | ✅ |
| Domain dedup | ✅ | ✅ | ✅ | ✅ | ✅ |
| URL | 200 ✅ | 200 ✅ | 200 ✅ | 200 ✅ | 200 ✅ |
| Domain format | ✅ | ✅ | ✅ | ✅ | ✅ |
| HTTPS | ✅ | ✅ | ✅ | ✅ | ✅ |
Issue:
⚠️ china/technology/industry_associations/china-sae.json— 目录名用了下划线(industry_associations),应改为连字符(industry-associations)以保持项目风格一致
修复后可 approve。
mingcha-dev
approved these changes
Apr 28, 2026
Collaborator
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 Re-review — PR #187 APPROVED ✅ 修复验证通过。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
新增5个中国权威数据源(下午批次)
新增数据源
质量检查
make check通过(545个ID全部唯一,schema验证通过)