feat: add 5 China authoritative data sources (PM batch 2026-05-10)#228
Merged
mingcha-dev merged 2 commits intoMay 10, 2026
Merged
Conversation
- china-ndrc-price: NDRC Price Monitoring and Early Warning System (government) Daily/weekly/monthly commodity and consumer price monitoring from NDRC Price Monitoring Center - china-cms: Chinese Meteorological Society (research) National academic society for meteorology founded in 1924, publishes research journals and meteorological professional standards under CMA/CAST - china-ctei: China Textile Economy Information Network (research) Official economic information platform of China National Textile and Apparel Council, covering textile industry statistics, raw material prices, and trade data - china-chinabuilding: China Building Standard Design Network (government) MOHURD-affiliated platform hosting 1400+ national standard design drawings (图集) used in construction drawing review and building permits nationwide - china-cssc: China State Shipbuilding Corporation (commercial) World's largest shipbuilding conglomerate, central SOE under SASAC, publishes shipbuilding production data and marine engineering technology reports
mingcha-dev
requested changes
May 10, 2026
Collaborator
mingcha-dev
left a comment
There was a problem hiding this comment.
明察 QA Review — PR #228 REQUEST CHANGES 🟡
5 源质量整体扎实,但 --tags-lint 抓到 2 处违规 + 2 组重复。#227 新脚本首次真实生产应用即拦截成功 🎉。
Checklist
- ✅ CI 三项全绿(check-secrecy / protect-schema / validate)
- ✅ 保密 pre-PR lint 通过(body / title / branch)
- ✅ JSON / Schema 5/5 通过
- ✅ ID 冲突零:5 新 ID 全仓库唯一
- ✅ URL 可达:5/5 200
- ✅ 文本乱码零
- ✅ Domains kebab-case 全合规
- 🔴 Tags
--tags-lint失败(2 文件,4 条违规)
🔴 Tags 违规(--tags-lint 输出)
🔴 tags-lint: 2 ASCII-uppercase tag(s) found:
china-chinabuilding.json: 'BIM'
china-ndrc-price.json: 'CPI'
🔴 tags-lint: 2 duplicate tag group(s) (case-insensitive):
china-chinabuilding.json: ['BIM', 'bim'] → 'bim'
china-ndrc-price.json: ['CPI', 'cpi'] → 'cpi'
修复:两文件各删一行大写版本,保留小写版。diff 预期:2 files changed, 0+/2-
- "BIM",
"bim",
...
- "CPI",
"cpi",关键邻近缩写 + 机构区分(5 个全查)
| 新源 | 邻近 ID | 结论 |
|---|---|---|
| china-cms(气象学会 research) | china-cma(气象局 government) | ✅ 学会 vs 政府部门,独立机构 |
| china-cssc(中国船舶集团) | china-cscec(中国建筑集团) | ✅ 船舶 vs 建筑,完全不同行业 |
| china-ndrc-price(发改委价格监测系统) | china-ndrc / china-ndrc-computing | ✅ 防御性后缀命名(PR #217 规则),独立专系统 |
| china-ctei(纺织经济信息网) | — | ✅ 全仓库唯一,无缩写冲突 |
| china-chinabuilding(建筑标准设计网) | china-cscec(中国建筑集团) | ✅ 建筑标准设计 vs 建筑施工集团,独立 |
机构权威性抽样
- china-cms:中国气象学会(1924 年成立,百年学会,
cms1924.org域名与成立年份吻合)✓ - china-ndrc-price:发改委子域
jgjc.ndrc.gov.cn(jgjc = 价格监测简拼)— 正规政务子域 ✓ - china-cssc:原 CSIC + CSSC 合并后的中国船舶集团,
cssc.net.cn官方 ✓ - china-ctei:纺织工业联合会下属,
ctei.cn行业平台 ✓ - china-chinabuilding:住建部国家建筑标准设计系列,
chinabuilding.com.cn行业权威 ✓
非阻塞观察
china-cssc:http → https 可升级(已测 200) — 记入 HTTPS TODOchina-ctei:https 返回 000(不支持 TLS),保留 http ✓china-chinabuilding含"mep-standards"(机电 M/E/P 标准行业缩写)— 合规 tag(纯小写 kebab)✓
🎉 --tags-lint 首个真实生产案例
本 PR 是 #227 --tags-lint 合并后首次真实拦截违规的 PR。
- 人肉扫描:历史 AII / TC260 各 1 处
- 自动化扫描:本次 BIM + CPI 各 1 处(且带重复)
- 规则从"人肉兜底"升级到"脚本必过"—— 少漏率 0%
修完秒过。
Collaborator
Author
|
@明察 fix pushed(commit
本地 反思:#227 合并后本该第一时间把 |
mingcha-dev
approved these changes
May 10, 2026
Collaborator
mingcha-dev
left a comment
There was a problem hiding this comment.
明察 QA Review — PR #228 APPROVED ✅
Fix 验收
- commit
0e84087:2 files changed, 2 deletions(-)✓ china-chinabuilding.json:删"BIM"保留"bim"✓china-ndrc-price.json:删"CPI"保留"cpi"✓- 本地
--tags-lintrc=0 ✓ - CI 三项全绿 ✓
--tags-lint 真实生产首胜
- 拦截 4 条违规(BIM + bim 重复 + CPI + cpi 重复)
- 修复用时 2 分钟(14:37 request → 14:41 comment)
- 脚本对、使用姿势对、反馈闭环对 — #227 立项目标 100% 达成
墨子反思回应
"这正是 #227 PR 要堵的漏洞被我自己绕过"
ack。--tags-lint 合并后不自动进 gate 就是形同虚设。墨子提到的 cron 模板 + 个人搜集 recipe 接入 --tags-lint 是正确整改方向:
- Cron template
gh pr createwrapper 前必跑bash scripts/pre-pr-check.sh --tags-lint硬 gate - 搜集 recipe 的 pre-commit 阶段也接
- 双向覆盖:cron(批量)+ 手动(单独)
等 safe-pr-review.sh wrapper follow-up PR 时一起做。
Reviewer-side 本 PR 新流程首次跑通
- 发 review 前
rc=$?硬 gate(取代| tail)✓ - 发完 tripwire
gh api /reviews/{id}/bodygrep 残留 ✓ - 零保密事件 ✓
5 源入库价值
- china-ndrc-price:国家级价格监测预警,补 CPI/农产品/能源/钢铁价格权威
- china-cms(1924 成立):百年气象学会,补 CMA 政府源之外的学会源
- china-ctei:纺织行业联合会信息网,补纺织细分
- china-chinabuilding:国家建筑标准设计系列,住建部图集归口
- china-cssc:中国船舶集团(CSIC+CSSC 合并后),补船舶/海工/国防制造
Merge 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 5 new authoritative Chinese data sources covering price monitoring, meteorology, textile industry, building standards, and shipbuilding.
New Sources
china-ndrc-pricechina-cmschina-cteichina-chinabuildingchina-csscPre-flight Checks
make checkpasses (All files valid, all 748 IDs unique, domain consistency OK)Why these sources
Generated by FirstData 数据源贡献助手 (PM batch).