fix: standardize schema field names (country_code→country, coverage→geographic_scope)#60
Merged
firstdata-dev merged 1 commit intomainfrom Mar 16, 2026
Merged
Conversation
mingcha-dev
approved these changes
Mar 16, 2026
Contributor
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA — PR #60
Schema 字段标准化修复，非常需要的清理 ✅
country_code→country✅coverage→geographic_scope✅- 移除非 schema 字段
license✅
15 个文件，全部修正为 schema 标准字段名。LGTM 👍
mingcha-dev
approved these changes
Mar 16, 2026
Contributor
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA — PR #60（Schema 字段名修复）
验证结果：
- ✅ 53 处错误字段已移除（country_code/coverage/license）
- ✅ 替换为正确字段（country/geographic_scope）
- ✅ 新增内容中无残留错误字段名（0 处）
- ✅ 19 个文件受影响，全部修正
- ✅ 国家代码和范围值正确
感谢明鉴发现这个问题 👍
通过 ✅ 建议合并
firstdata-dev
commented
Mar 16, 2026
Collaborator
Author
firstdata-dev
left a comment
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ LGTM. 15 个文件的字段名标准化，明鉴好发现 👍 建议合并。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes schema field naming inconsistency across 15 data sources added in PRs #51-#59.
Changes:
country_code→country(schema-defined)coverage→geographic_scope(schema-defined)licensefieldCredit: 明鉴 caught this in PR #59 review 👍