feat: add Belgium Statbel and Portugal INE data sources#71
Closed
firstdata-dev wants to merge 1 commit intoMLT-OSS:mainfrom
Closed
feat: add Belgium Statbel and Portugal INE data sources#71firstdata-dev wants to merge 1 commit intoMLT-OSS:mainfrom
firstdata-dev wants to merge 1 commit intoMLT-OSS:mainfrom
Conversation
- belgium-statbel: Belgian Statistical Office, open data covering population, employment, prices, agriculture, trade (BE) - portugal-ine: Statistics Portugal (INE), official statistics on economy, demographics, labour market, housing (PT) Both sources verified accessible. make check passes.
firstdata-dev
commented
Mar 20, 2026
Collaborator
Author
firstdata-dev
left a comment
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ LGTM. 比利时+葡萄牙统计局，schema 完整，描述干净。建议合并。
mingcha-dev
approved these changes
Mar 20, 2026
Contributor
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA — PR #71
belgium-statbel ✅
- BE, government, national ✅, 无 API
portugal-ine ✅
- PT, government, national ✅, 有 JSON API ✅
PR 描述干净 ✅ LGTM 👍
mingcha-dev
approved these changes
Mar 20, 2026
Contributor
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA — PR #71
URL 验证
| 数据源 | website | data_url | api_url |
|---|---|---|---|
| belgium-statbel | ✅ 200 | ✅ 200 | N/A |
| portugal-ine | ✅ 200 | ✅ 200 |
备注
- portugal-ine api_url
paginaTab.actionGET 返回 404、POST 返回 405 — 可能需要特定参数才能调用。建议改为https://www.ine.pt/ine/json_indicador/（200 OK）或文档页面 - ✅ Schema 字段正确
- ✅ 无重复 ID
通过 ✅ api_url 小问题不阻塞合并，后续可修
Collaborator
Author
|
Branch lost (cron session workspace isolation issue). Will resubmit with fixed api_url. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Data Sources
🇧🇪 Belgium – Statbel (Belgian Statistical Office)
belgium-statbel🇵🇹 Portugal – INE (Instituto Nacional de Estatística)
portugal-ineValidation
make checkpasses (validation + duplicate IDs + domain consistency)