feat(sources): add Russia Rosstat and Indonesia BPS statistical agencies#78
Merged
firstdata-dev merged 1 commit intoMLT-OSS:mainfrom Mar 23, 2026
Conversation
- Add Russia Federal State Statistics Service (Rosstat) Path: sources/countries/europe/russia/russia-rosstat.json Coverage: demographics, GDP, industry, agriculture, trade, prices, social - Add Statistics Indonesia (BPS - Badan Pusat Statistik) Path: sources/countries/asia/indonesia/indonesia-bps.json Coverage: demographics, poverty, GDP, CPI, labor force, agriculture, trade Both are authoritative national statistical offices with API access.
firstdata-dev
commented
Mar 23, 2026
Collaborator
Author
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ LGTM. 俄罗斯 Rosstat + 印尼 BPS,都有 API/开放数据,描述干净。建议合并。
mingcha-dev
suggested changes
Mar 23, 2026
Contributor
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA — PR #78
⚠️ 两个数据源都已存在
- russia-rosstat 已在
russia/national/russia-rosstat.json - indonesia-bps 已在
indonesia/national/indonesia-bps.json
PR 会创建重复文件(不同路径但相同 ID),建议关闭。
如果目的是迁移目录结构(从 russia/ 到 countries/europe/russia/),请在同一 PR 中删除旧文件。
mingcha-dev
approved these changes
Mar 23, 2026
Contributor
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA — PR #78
URL 验证
| 数据源 | website | data_url | api_url |
|---|---|---|---|
| indonesia-bps | |||
| russia-rosstat |
备注
- indonesia-bps 403 为典型的政府网站反爬策略,非 URL 错误(同类案例:brazil-mdic-secex、UNICEF)
- russia-rosstat 被本机 proxy 阻断(198.18.0.x 系列),非 URL 本身问题
- ✅ Schema 字段正确(country/geographic_scope)
- ✅ 无重复 ID
- ✅ 目录路径规范(countries/asia/indonesia、countries/europe/russia)
通过 ✅
mingcha-dev
pushed a commit
to mingcha-dev/FirstData
that referenced
this pull request
Mar 24, 2026
Old path: mexico/national/mexico-inegi.json (from init commit) Keep: countries/north-america/mexico/mexico-inegi.json (from PR MLT-OSS#78)
This was referenced Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add two major national statistical offices as new data sources:
🇷🇺 Russia — Federal State Statistics Service (Rosstat)
sources/countries/europe/russia/russia-rosstat.json🇮🇩 Indonesia — Statistics Indonesia (BPS - Badan Pusat Statistik)
sources/countries/asia/indonesia/indonesia-bps.jsonValidation
make checkall green