Add batch optimization, listening-note preference learning, and waveform preview#12
Open
Add batch optimization, listening-note preference learning, and waveform preview#12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
optimaster optimize-batch ...to run optimization over multiple files andoptimaster add-note ...to save listening ratings (changes insrc/optimaster/cli.py).PreferenceStoreto persist notes and compute per-preset bias, saved torenders/preferences.json, and aPreferenceStoreAPI (src/optimaster/preferences.py).EngineService.optimizeso saved listening notes adjust candidate scores and append a scoring reason when bias is applied (src/optimaster/service.py).render_waveform_previewand wired it into the GUI to display a waveform image after file selection, plus rating controls and a "Save listening note" action in the recommended candidate panel (src/optimaster/ffmpeg.py,src/optimaster/gui.py).README.md,TASKS_MASTER.md) and added unit testtests/test_preferences.pycovering preference persistence and bias direction.Testing
PYTHONPATH=src pytest -qand all tests passed:5 passed.python -m py_compilefor the modified modules and it succeeded forsrc/optimaster/gui.py,cli.py,service.py,ffmpeg.py,preferences.py.pytest -qrun initially failed in this environment because the package root was not onPYTHONPATH, so tests were re-run withPYTHONPATH=srcand succeeded.Codex Task