Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
destination_profileandstrict_true_peaktoWorkerRequestand threaded these through the worker toEngineService.optimizeinsrc/optimaster/gui.pyandsrc/optimaster/service.py.DESTINATION_SCORING_OVERRIDESand a_runtime_scoring_confighelper inEngineServiceto apply destination-specific overrides and tighten true-peak limits usingdataclasses.replacebefore scoring.QComboBox, aQCheckBoxfor strict true-peak, minor diagnostic and UX text improvements, and additional candidate detail lines (delta vs source and a listening checklist).tests/test_service_profiles.pythat verify destination overrides and strict true-peak capping behavior.Testing
pytest tests/test_service_profiles.pywhich passed.pytest -qand observed no regressions in the test run related to the changes.Codex Task