Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
analyzethenoptimize, butoptimize()always re-ran full source analysis, causing redundant work and slower time-to-results.Description
_ffmpeg_checkedflag and_ensure_ffmpeg_available()inEngineServiceto runassert_ffmpeg_available()only once per service instance.EngineService.optimize()with an optionalsource_analysisparameter and logic to reuse a providedSourceAnalysiswhen it matches the input file, avoiding a second analysis.WorkerRequestandEngineWorkerto carrysource_analysisand wiredMainWindowto pass a cached analysis when the selected input file matches the current analysis, and to invalidate the cached analysis when the user changes file.tests/test_service.pywith unit tests that verify FFmpeg availability is checked once per instance and thatoptimize()reuses precomputed analysis without re-invokinganalyze_source().Testing
pytest -q(default) which initially failed collection due tooptimasterimport resolution in this environment.PYTHONPATH=src pytest -qwhich executed the test suite and produced6 passed.Codex Task