refactor(models): distinguish source repo via prefix #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a prefix to model names identifying which repository the model is from (i.e., what "kind" of model it is):
example/...example models from https://github.com/MODFLOW-ORG/modflow6-examplestest/...test models from https://github.com/MODFLOW-ORG/modflow6-testmodels (only mf6)large/...models from https://github.com/MODFLOW-ORG/modflow6-largetestmodelsThis will allow more easily selecting subsets of models by the repository they are from as we do in MF6 autotests.
I considered adding an "mf6" prefix to all these (useful if we want to expose older models, e.g. from the mf5to6 folder in the test models repo). I also considered making the prefix identical to the repository name. Not sure which way is best, this will do for now. Anyone reading this with an opinion, please make it known.
Also, remove the auto-generated model functions (doesn't play nice with "namespaced" i.e. "/"-delimited model names), tweak the registry introspection functions for consistency, and update some docstrings.