refactor(fixtures): fix/refactor model-loading fixtures#33
Merged
Conversation
* refactor test model fixtures as path to namefile, not model dir * refactor model-loading utility functions for distinct use cases * expand tests * update docs
wpbonelli
force-pushed
the
fix-fixtures
branch
from
fdc8129 to
d2afc0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pathto namefile rather than model directory, affects the following fixturestest_model_mf6test_model_mf5to6large_test_modelget_model_paths()utility function intoget_model_dir_paths()get_namefile_paths()This PR introduces a breaking change for model-loading fixtures. Previously the fixtures were
Paths to the model directory, i.e. the folder containing the model's namefile. This caused ambiguity and/or duplication if a folder contained multiple namefiles. Since namefiles contain relative paths to inputs, it should be sufficient to provide the namefile path alone to test functions.This PR does not change the
example_scenariofixture, which is still aTuple[str, List[Path]]mapping scenario name to ordered list of namefile paths.