Skip to content

fix: define proper interfaces for navprops#1212

Merged
MODSetter merged 2 commits intoMODSetter:devfrom
mmatsumoto1026:fix/define-proper-interfaces-for-navprops
Apr 10, 2026
Merged

fix: define proper interfaces for navprops#1212
MODSetter merged 2 commits intoMODSetter:devfrom
mmatsumoto1026:fix/define-proper-interfaces-for-navprops

Conversation

@mmatsumoto1026
Copy link
Copy Markdown
Contributor

@mmatsumoto1026 mmatsumoto1026 commented Apr 10, 2026

Description

This PR was opened to define interfaces which relate to DesktopNav and MobileNav components to enhance the TypeScript’s ability to catch errors at compile time.

Motivation and Context

FIX #1196

Screenshots

API Changes

  • This PR includes API changes

Change Type

  • Bug fix
  • New feature
  • Performance improvement
  • Refactoring
  • Documentation
  • Dependency/Build system
  • Breaking change
  • Other (specify):

Testing Performed

  • Tested locally by using the command pnpm --filter surfsense_web exec tsc --noEmit
  • Manual/QA verification

Checklist

  • Follows project coding standards and conventions
  • Documentation updated as needed
  • Dependencies updated as needed
  • No lint/build errors or new warnings
  • All relevant tests are passing

High-level PR Summary

This PR replaces any types with properly defined TypeScript interfaces for the DesktopNav and MobileNav components in the navbar. It introduces NavItem, DesktopNavProps, and MobileNavProps interfaces to improve type safety and enable better compile-time error detection.

⏱️ Estimated Review Time: 5-15 minutes

💡 Review Order Suggestion
Order File Path
1 surfsense_web/components/homepage/navbar.tsx

Need help? Join our Discord

Analyze latest changes

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 10, 2026

@mmatsumoto1026 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown

@recurseml recurseml bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by RecurseML

🔍 Review performed on 649f315..1948f08

✨ No bugs found, your code is sparkling clean

✅ Files analyzed, no issues (1)

surfsense_web/components/homepage/navbar.tsx

@MODSetter MODSetter merged commit e273197 into MODSetter:dev Apr 10, 2026
1 of 2 checks passed
@mmatsumoto1026 mmatsumoto1026 deleted the fix/define-proper-interfaces-for-navprops branch April 10, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants