fix: define proper interfaces for navprops#1212
Merged
MODSetter merged 2 commits intoMODSetter:devfrom Apr 10, 2026
Merged
Conversation
|
@mmatsumoto1026 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on 649f315..1948f08
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (1)
• surfsense_web/components/homepage/navbar.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR was opened to define interfaces which relate to
DesktopNavandMobileNavcomponents to enhance the TypeScript’s ability to catch errors at compile time.Motivation and Context
FIX #1196
Screenshots
API Changes
Change Type
Testing Performed
pnpm --filter surfsense_web exec tsc --noEmitChecklist
High-level PR Summary
This PR replaces
anytypes with properly defined TypeScript interfaces for theDesktopNavandMobileNavcomponents in the navbar. It introducesNavItem,DesktopNavProps, andMobileNavPropsinterfaces to improve type safety and enable better compile-time error detection.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_web/components/homepage/navbar.tsx