perf: optimize next/image sizes with dynamic maxWidth (#1089)#1222
Merged
MODSetter merged 1 commit intoMODSetter:devfrom Apr 14, 2026
Merged
perf: optimize next/image sizes with dynamic maxWidth (#1089)#1222MODSetter merged 1 commit intoMODSetter:devfrom
MODSetter merged 1 commit intoMODSetter:devfrom
Conversation
|
@oscarzhou511 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on e1e4bb4..0bdc081
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (1)
• surfsense_web/components/tool-ui/image/index.tsx
Contributor
Author
|
Thank you very much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that next/image sizes are optimized by using dynamic maxWidth.
Description
surfsense_web/components/tool-ui/image/index.tsxto use dynamicsizesvalues based on themaxWidthprop for both auto-ratio and fixed-ratio images.features-bento-grid.tsxuses responsive sizes matching its grid column widths:(max-width: 768px) 100vw, (max-width: 1024px) 50vw, 33vw.mdx-components.tsxincludes a sensible default for Markdown images:(max-width: 768px) 100vw, 896px.Motivation and Context
FIX #1089 - modifying next/image sizes use dynamic maxWidth
API Changes
Change Type
Testing Performed
sizesattribute correctly reflects themaxWidthprop.Checklist
Hopefully this helps the SurfSense project ;)
Oscar
High-level PR Summary
This PR optimizes the
next/imagecomponent's responsive image loading by replacing hardcodedsizesattributes with dynamic values based on themaxWidthprop. The changes ensure that both auto-ratio and fixed-ratio images generate appropriate size hints for the browser, improving image loading performance and reducing unnecessary bandwidth usage.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_web/components/tool-ui/image/index.tsx