fix(hitl-edit-panel): move duplicate-tag check into functional setTags (#1248)

[mvanhorn]

Summary

Fixes #1248

handleAddTag in EmailsTagField (surfsense_web/components/hitl-edit-panel/hitl-edit-panel.tsx) listed tags in its useCallback dependency array only so the closure-level duplicate check could read it. That had two side effects the issue calls out:

1. The callback re-created on every tag mutation, invalidating memoization for downstream consumers.
2. The duplicate check saw closure-level tags, not the latest state, so rapid adds could race.

Change

Move the duplicate check inside the functional setTags updater so it always sees the latest state, and drop tags from the dependency array. The callback is now stable for the component's lifetime.

-const handleAddTag = useCallback(
-    (text: string) => {
-        const trimmed = text.trim();
-        if (!trimmed) return;
-        if (tags.some((tag) => tag.text === trimmed)) return;
-        const newTag: TagType = { id: Date.now().toString(), text: trimmed };
-        setTags((prev) => [...prev, newTag]);
-    },
-    [tags]
-);
+const handleAddTag = useCallback((text: string) => {
+    const trimmed = text.trim();
+    if (!trimmed) return;
+    setTags((prev) => {
+        if (prev.some((tag) => tag.text === trimmed)) return prev;
+        const newTag: TagType = { id: Date.now().toString(), text: trimmed };
+        return [...prev, newTag];
+    });
+}, []);

Testing

• pnpm biome check components/hitl-edit-panel/hitl-edit-panel.tsx - clean
• pnpm biome lint components/hitl-edit-panel/hitl-edit-panel.tsx - clean

Pre-existing tsc errors in app/(home)/blog/[slug]/page.tsx are unrelated to this change.

High-level PR Summary

This PR fixes a React hooks optimization issue in the EmailsTagField component by moving the duplicate-tag check from the closure scope into the functional state updater. This eliminates unnecessary callback re-creation on every tag mutation and prevents race conditions when adding tags rapidly, ensuring the duplicate check always sees the latest state while maintaining a stable callback reference.

⏱️ Estimated Review Time: 5-15 minutes

💡 Review Order Suggestion

Order	File Path
1	surfsense_web/components/hitl-edit-panel/hitl-edit-panel.tsx

[vercel]

@mvanhorn is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 81c45b7e-6d66-4379-bf3d-ac8d1a0078d9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[recurseml]

Review by RecurseML

🔍 Review performed on 3f30b12..7f0a5cd

✨ No bugs found, your code is sparkling clean

✅ Files analyzed, no issues (1)

• surfsense_web/components/hitl-edit-panel/hitl-edit-panel.tsx

[mvanhorn]

Thanks for the merge, @MODSetter. Functional setTags is the right home for that check.