Skip to content

fix: remove unnecessary publisherName from Windows signing command#1282

Merged
MODSetter merged 2 commits intomainfrom
dev
Apr 21, 2026
Merged

fix: remove unnecessary publisherName from Windows signing command#1282
MODSetter merged 2 commits intomainfrom
dev

Conversation

@MODSetter
Copy link
Copy Markdown
Owner

@MODSetter MODSetter commented Apr 21, 2026

Description

Motivation and Context

FIX #

Screenshots

API Changes

  • This PR includes API changes

Change Type

  • Bug fix
  • New feature
  • Performance improvement
  • Refactoring
  • Documentation
  • Dependency/Build system
  • Breaking change
  • Other (specify):

Testing Performed

  • Tested locally
  • Manual/QA verification

Checklist

  • Follows project coding standards and conventions
  • Documentation updated as needed
  • Dependencies updated as needed
  • No lint/build errors or new warnings
  • All relevant tests are passing

High-level PR Summary

This PR removes a redundant publisherName configuration parameter from the Windows signing command in the desktop release workflow. The publisher name is already being set in the azureSignOptions object, making the top-level win.publisherName parameter unnecessary.

⏱️ Estimated Review Time: 5-15 minutes

💡 Review Order Suggestion
Order File Path
1 .github/workflows/desktop-release.yml

Need help? Join our Discord

Analyze latest changes

Summary by CodeRabbit

  • Chores
    • Updated Windows release build configuration to remove redundant signing parameter while preserving core signing functionality.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
surf-sense-frontend Building Building Preview, Comment Apr 21, 2026 9:05am

Request Review

@MODSetter MODSetter merged commit 1213535 into main Apr 21, 2026
1 of 3 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 30b16a1b-84a5-41d5-95f2-90fcbfdd25af

📥 Commits

Reviewing files that changed from the base of the PR and between 27d081a and e3a1cc1.

📒 Files selected for processing (1)
  • .github/workflows/desktop-release.yml

📝 Walkthrough

Walkthrough

The desktop release GitHub Actions workflow removes a Windows publisher name CLI argument from the Electron Builder command. This parameter was previously appended during the Windows signing process, but is no longer included in the build configuration.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/desktop-release.yml
Removed the -c.win.publisherName="$WINDOWS_PUBLISHER_NAME" Electron Builder CLI argument from the Windows signing conditional block; other signing-related options remain intact.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 The publisher's name fades away,
One line removed from the build today,
Simpler configs, lighter weight,
Windows workflows set their fate! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@recurseml recurseml Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by RecurseML

🔍 Review performed on 27d081a..e3a1cc1

✨ No bugs found, your code is sparkling clean

✅ Files analyzed, no issues (1)

.github/workflows/desktop-release.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant