-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix for write_todo tool & UI Improvements
#642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ndexing documents
…der shimmer display logic.
…nd visual consistency across various components.
…own, and remove unused imports.
… elements on authentication pages
|
@AnishSarkar22 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review by RecurseML
🔍 Review performed on 0e1ea9c..5bd26ab
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (33)
• surfsense_web/app/(home)/login/GoogleLoginButton.tsx
• surfsense_web/app/(home)/login/LocalLoginForm.tsx
• surfsense_web/app/(home)/login/page.tsx
• surfsense_web/app/(home)/register/page.tsx
• surfsense_web/app/dashboard/[search_space_id]/client-layout.tsx
• surfsense_web/app/dashboard/[search_space_id]/connectors/(manage)/page.tsx
• surfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/DocumentsFilters.tsx
• surfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/DocumentsTableShell.tsx
• surfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/ProcessingIndicator.tsx
• surfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/RowActions.tsx
• surfsense_web/app/dashboard/[search_space_id]/documents/(manage)/page.tsx
• surfsense_web/app/dashboard/[search_space_id]/logs/(manage)/page.tsx
• surfsense_web/app/dashboard/[search_space_id]/sources/add/page.tsx
• surfsense_web/app/dashboard/[search_space_id]/team/page.tsx
• surfsense_web/app/dashboard/page.tsx
• surfsense_web/components/LanguageSwitcher.tsx
• surfsense_web/components/UserDropdown.tsx
• surfsense_web/components/assistant-ui/thread.tsx
• surfsense_web/components/inference-params-editor.tsx
• surfsense_web/components/json-metadata-viewer.tsx
• surfsense_web/components/new-chat/document-mention-picker.tsx
• surfsense_web/components/new-chat/model-config-sidebar.tsx
• surfsense_web/components/new-chat/model-selector.tsx
• surfsense_web/components/new-chat/source-detail-panel.tsx
• surfsense_web/components/shared/llm-config-form.tsx
• surfsense_web/components/sidebar/all-chats-sidebar.tsx
• surfsense_web/components/sidebar/all-notes-sidebar.tsx
• surfsense_web/components/sidebar/nav-chats.tsx
• surfsense_web/components/sidebar/nav-notes.tsx
• surfsense_web/components/sources/ConnectorsTab.tsx
• surfsense_web/components/sources/DocumentUploadTab.tsx
• surfsense_web/components/sources/YouTubeTab.tsx
• surfsense_web/components/ui/dialog.tsx
…d task management
…ttings components for improved user experience
write_todo tool & UI Improvements
write_todotool. Now todo tool has different behaviour all together when connectors are taken into account. The previous behaviour for normal planning tasks are kept same.Description
Motivation and Context
FIX #
Screenshots
API Changes
Change Type
Testing Performed
Checklist
High-level PR Summary
This PR implements comprehensive mobile responsiveness across the entire application, including authentication pages, dashboard layouts, sidebars, forms, and tables. The changes adapt spacing (
px,py,gap), typography sizes (text-xs,text-sm,md:text-base), button and input heights, and component layouts to work well on smaller screens using Tailwind's responsive breakpoints (sm:,md:,lg:). Additionally, it fixes a bug with the document processing indicator to only show for upload tasks (not periodic reindexing) and includes minor improvements like dependency array corrections and better mobile dropdown menu behavior.⏱️ Estimated Review Time: 30-90 minutes
💡 Review Order Suggestion
surfsense_web/components/LanguageSwitcher.tsxsurfsense_web/components/UserDropdown.tsxsurfsense_web/components/ui/dialog.tsxsurfsense_web/app/(home)/login/GoogleLoginButton.tsxsurfsense_web/app/(home)/login/LocalLoginForm.tsxsurfsense_web/app/(home)/login/page.tsxsurfsense_web/app/(home)/register/page.tsxsurfsense_web/app/dashboard/page.tsxsurfsense_web/app/dashboard/[search_space_id]/client-layout.tsxsurfsense_web/components/sidebar/nav-chats.tsxsurfsense_web/components/sidebar/nav-notes.tsxsurfsense_web/components/sidebar/all-chats-sidebar.tsxsurfsense_web/components/sidebar/all-notes-sidebar.tsxsurfsense_web/components/new-chat/model-selector.tsxsurfsense_web/components/new-chat/model-config-sidebar.tsxsurfsense_web/components/new-chat/source-detail-panel.tsxsurfsense_web/components/new-chat/document-mention-picker.tsxsurfsense_web/components/assistant-ui/thread.tsxsurfsense_web/components/shared/llm-config-form.tsxsurfsense_web/components/inference-params-editor.tsxsurfsense_web/components/json-metadata-viewer.tsxsurfsense_web/app/dashboard/[search_space_id]/connectors/(manage)/page.tsxsurfsense_web/app/dashboard/[search_space_id]/documents/(manage)/page.tsxsurfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/ProcessingIndicator.tsxsurfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/DocumentsFilters.tsxsurfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/DocumentsTableShell.tsxsurfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/RowActions.tsxsurfsense_web/app/dashboard/[search_space_id]/logs/(manage)/page.tsxsurfsense_web/app/dashboard/[search_space_id]/sources/add/page.tsxsurfsense_web/components/sources/DocumentUploadTab.tsxsurfsense_web/components/sources/YouTubeTab.tsxsurfsense_web/components/sources/ConnectorsTab.tsxsurfsense_web/app/dashboard/[search_space_id]/team/page.tsx