[FEAT] Prompt suggestions and role editing. #763
Merged
+421
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elammertsma is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on a0bbd9e..f23aaa2
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (3)
• surfsense_web/app/dashboard/[search_space_id]/team/page.tsx
• surfsense_web/components/assistant-ui/inline-mention-editor.tsx
• surfsense_web/components/assistant-ui/thread.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cycling prompt suggestions (placeholder text) in the chat and (re)added role editing.
Description
Motivation and Context
Many users seem not to know where to start with SurfSense, so cycling a few prompt suggestions may inspire them to find good uses. Suggestions include podcasts, querying connectors and cross-referencing information/connectors.
Additionally, the role editor was not displaying when "Edit role" was clicked. I readded this but perhaps there was a reason for removing it that I'm unaware of.
Screenshots
API Changes
Change Type
Testing Performed
Checklist
High-level PR Summary
This PR introduces two user experience improvements: cycling prompt suggestions that rotate through helpful examples every 6 seconds when the chat is empty to inspire new users, and role editing functionality that was previously broken. The cycling placeholders include suggestions for podcasts, connector queries, and cross-referencing information. The role editor now properly displays when "Edit role" is clicked, allowing users to modify role names, descriptions, permissions, and default status.
⏱️ Estimated Review Time: 15-30 minutes
💡 Review Order Suggestion
surfsense_web/components/assistant-ui/inline-mention-editor.tsxsurfsense_web/components/assistant-ui/thread.tsxsurfsense_web/app/dashboard/[search_space_id]/team/page.tsx