Improving types #218
Merged
Improving types #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
reviewed
Aug 9, 2018
| width: number; | ||
| height: number; | ||
| updated_at: string; | ||
| alt: string | null; |
Collaborator
There was a problem hiding this comment.
This is not documented, https://help.shopify.com/en/api/reference/products/product_image is it available?
Contributor
Author
There was a problem hiding this comment.
It is as far as I can see in all responses (shown in documentation) involving images, did some tests and I did get them when available and as null when not set.
lpinca
approved these changes
Aug 9, 2018
Collaborator
|
Thank you. |
Contributor
Author
|
Thank you @lpinca for all the work here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, adding some improvements on types for #217