Skip to content

Improving types #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2018
Merged

Improving types #218

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d560e60
Improvements on types for latest Shopify API
NeurAlch Aug 9, 2018
c576672
Alt attribute seems to always come as null or string
NeurAlch Aug 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,6 +646,7 @@ declare namespace Shopify {
src: string;
updated_at?: string;
width: number;
alt: string | null;
}

interface IBase64Image {
Expand Down Expand Up @@ -1429,10 +1430,10 @@ declare namespace Shopify {
created_at: string;
handle: string;
id: number;
metafield: string;
metafield: IObjectMetafield[];
published_at: string;
shop_id: number;
template_suffic: string | null;
template_suffix: string | null;
title: string;
updated_at: string;
}
Expand Down Expand Up @@ -1491,7 +1492,7 @@ declare namespace Shopify {
created_at: string;
handle: string;
id: number;
image: any | null;
image: IProductImage;
images: IProductImage[];
options: IProductOption[];
product_type: string;
Expand All @@ -1516,6 +1517,7 @@ declare namespace Shopify {
width: number;
height: number;
updated_at: string;
alt: string | null;
Copy link
Collaborator

@lpinca lpinca Aug 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not documented, https://help.shopify.com/en/api/reference/products/product_image is it available?

Copy link
Contributor Author

@NeurAlch NeurAlch Aug 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is as far as I can see in all responses (shown in documentation) involving images, did some tests and I did get them when available and as null when not set.

Copy link
Collaborator

@lpinca lpinca Aug 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thank you.

}

type ProductVariantInventoryPolicy = "deny" | "continue";
Expand Down