[pull] main from pytorch:main#1088
Merged
pull[bot] merged 1 commit intoMPACT-ORG:mainfrom Apr 18, 2026
Merged
Conversation
…utotuner.run() (#179424) (#179424) Summary: Refactors the tail of `CachingAutotuner.run()` to separate launch instrumentation from the core kernel dispatch: - `_debug_call` is promoted from a local variable in `run()` to an instance attribute (initialized to None in __init__), so that `_post_launch` can access it without it being passed through the call. - `_pre_launch(launcher, *args, stream, **kwargs)`: extracts param dumping (`dump_launch_params`), tensor dumping (`dump_launch_tensors`), and profiler context-manager setup. Returns either a `_RecordFunctionFast` context or `nullcontext`. - `_post_launch()`: extracts the debug-mode finalization (`debug_call.finalize`). - `run()` is simplified to: call `_pre_launch`, enter its context manager around `launcher(...)`, call `_post_launch`. No behavioral change. See D99545697 for why we'd like to make this change. Test Plan: Run triton heuristics unit tests: buck test fbcode//mode/opt \ -m ovr_config//triton:beta \ -c fbcode.platform010_cuda_version=12.8 \ fbcode//caffe2/test/inductor:triton_heuristics Results: Ran 19 tests — 15 passed, 4 skipped, 0 failed Run the cold-run benchmark suite to verify end-to-end behavior: buck run fbcode//mode/opt \ -m ovr_config//triton:beta \ -c fbcode.platform010_cuda_version=12.8 \ fbcode//scripts/nmacchioni/aps-V4_0316tk_128gpu_coldrun_0324-8cae9b57d8:runner \ -- --times 10 --repeat 1 Results: (total runner duration to be filled after run) Differential Revision: D99538177 Pull Request resolved: #179424 Approved by: https://github.com/aorenste, https://github.com/jansel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )