Skip to content

Conversation

@amametjanov
Copy link
Contributor

Just a couple of typo fixes I noticed while building at ALCF-Mira.

@mgduda
Copy link
Contributor

mgduda commented Nov 20, 2013

Are you able to compile using the 'bluegene' target, e.g., using

make bluegene CORE=sw

Or is there another reason you're not able to make use of the 'bluegene' build target instead of the 'xlf' target?

Best regards,
Michael

@amametjanov
Copy link
Contributor Author

The xlf target was closer to the beginning of the makefile. :)

I tried both targets with commit 9681bbe and the build went through ok: specifically

  • make bluegene CORE=ocean
  • make xlf CORE=ocean

@mgduda
Copy link
Contributor

mgduda commented Nov 21, 2013

Regarding build targets, perhaps we should consider re-ordering these to reflect their expected frequency of use. The 'xlf' target had only been used on a POWER6 system that we had at NCAR, and which was replaced by 'yellowstone'. There are probably even some build targets that should be consolidated or removed altogether. Thanks, in any case for the pull request! I'll let one of the ocean developers look at the currently proposed changes.

@amametjanov
Copy link
Contributor Author

On a bluegene target, v2.0 seems to have a run-time problem that v1.5 doesn't: below is the error log. Any help?

2013-11-21 16:49:11.922 (INFO ) [0xfffb75eb970] 22722:ibm.runjob.AbstractOptions: using properties file /bgsys/local/etc/bg.properties
2013-11-21 16:49:11.923 (INFO ) [0xfffb75eb970] 22722:ibm.runjob.AbstractOptions: max open file descriptors: 65536
2013-11-21 16:49:11.923 (INFO ) [0xfffb75eb970] 22722:ibm.runjob.AbstractOptions: core file limit: 0
2013-11-21 16:49:11.924 (INFO ) [0xfffb75eb970] 22722:tatu.runjob.client: scheduler job id is 179764
2013-11-21 16:49:11.926 (INFO ) [0xfffb7bf3290] 22722:tatu.runjob.monitor: monitor started
2013-11-21 16:49:11.927 (INFO ) [0xfffb75eb970] CET-00000-11331-128:22722:ibm.runjob.client.options.Parser: set local socket to runjob_mux from properties file
2013-11-21 16:49:13.802 (INFO ) [0xfffb75eb970] CET-00000-11331-128:293255:ibm.runjob.client.Job: job 293255 started
Reading namelist.input
Reading namelist.input

Attempting to use an MPI routine before initializing MPICH

Attempting to use an MPI routine before initializing MPICH
2013-11-21 16:49:15.298 (INFO ) [0xfffb75eb970] CET-00000-11331-128:293255:ibm.runjob.client.Job: exited with status 1
2013-11-21 16:49:15.299 (WARN ) [0xfffb75eb970] CET-00000-11331-128:293255:ibm.runjob.client.Job: normal termination with status 1 from rank 0
2013-11-21 16:49:15.299 (INFO ) [0xfffb75eb970] tatu.runjob.client: task exited with status 1
2013-11-21 16:49:23.501 (INFO ) [0xfffb7bf3290] 22722:tatu.runjob.monitor: tracklib completed
2013-11-21 16:49:23.501 (INFO ) [0xfffb7bf3290] 22722:tatu.runjob.monitor: monitor terminating
2013-11-21 16:49:23.502 (INFO ) [0xfffb75eb970] tatu.runjob.client: monitor completed

@douglasjacobsen
Copy link
Member

Thanks, these were also proposed in: https://github.com/MPAS-Dev/MPAS-Release/pull/14 and will be included in the next release.

markjolah referenced this pull request in JCSDA-internal/MPAS-Model Sep 10, 2020
From discussion between Jake and Bill S
 - In MPAS initialization procedure from GFS analysis, there was a bug in moist air density formula.
 - In the formula, "temperature" should be replaced with "virtual temperature"
akturner added a commit that referenced this pull request Mar 19, 2021
…estcase

Added strain stress divergence test case
byoung-joo pushed a commit to byoung-joo/MPAS-Model that referenced this pull request Apr 6, 2021
Merge latest changes from upstream repository.  Works with mpas-jedi branch of the same name.  See that corresponding PR for more information on mpas-bundle behavior.

There are a lot of commits in this PR due to it having been a long time since such a merge was conducted.  The conflicts between the two branches are dealt with in commits 5beb733 and after.  Some small code changes from the early days of MPAS-JEDI development is removed, because it no longer serves a purpose.

After this PR is merged, `release-stable` will be nearly up to date with MPAS-Dev::develop with the following exceptions for code that is only in the JCSDA-internal fork:
- convective/cloud diagnostics for PANDA-C
- 2-stream I/O with a static file shared across all dates
- adjoint of some halo communications used for static B
- bug fixes in core_init_atmosphere for initializing `rho_zz` and `xice`
- optional cmake build process and dependence on the `jedi-cmake` repository

Closes MPAS-Dev#7
mark-petersen pushed a commit to mark-petersen/MPAS-Model that referenced this pull request Nov 16, 2021
…rgence_testcase

Added strain stress divergence test case
climbfuji pushed a commit to climbfuji/MPAS-Model that referenced this pull request Aug 25, 2022
Merge latest changes from upstream repository.  Works with mpas-jedi branch of the same name.  See that corresponding PR for more information on mpas-bundle behavior.

There are a lot of commits in this PR due to it having been a long time since such a merge was conducted.  The conflicts between the two branches are dealt with in commits 5beb733 and after.  Some small code changes from the early days of MPAS-JEDI development is removed, because it no longer serves a purpose.

After this PR is merged, `release-stable` will be nearly up to date with MPAS-Dev::develop with the following exceptions for code that is only in the JCSDA-internal fork:
- convective/cloud diagnostics for PANDA-C
- 2-stream I/O with a static file shared across all dates
- adjoint of some halo communications used for static B
- bug fixes in core_init_atmosphere for initializing `rho_zz` and `xice`
- optional cmake build process and dependence on the `jedi-cmake` repository

Closes MPAS-Dev#7
gcapodag pushed a commit to gcapodag/MPAS-Model that referenced this pull request Sep 29, 2022
MicroTed pushed a commit to MicroTed/MPAS-Model that referenced this pull request Jun 1, 2023
…_v7.3_smiol_lcc

Fix for bug causing excessive hourly convective precip accumulation
jderrico-noaa referenced this pull request in ufs-community/MPAS-Model Mar 29, 2024
… microphysics features (#2)

* Add microphysics submodule and updated graupel lookup table support (#1)

* microphysics Makefiles for submodule

* Add submodule support for microphysics

* Fix bug in Makefile directory path

* Thompson table updates for two-moment graupel

* Add aerosol aware microphysics capability (#2)

* Add microphysics aerosol information to initialization

* Link microphysics aerosol tables for runtime

* Update submodule

* Fix link to microphysics aerosol tables

* Add water- and ice-friendly aerosols to model for transport (#3)

* Update pointer for microphysics

* Update pointer to microphysics submodule

* Add microphysics aerosol information to LBCs

* Add aerosol-aware microphysics to LBCs (#4)

* Add microphysics aerosol information to LBCs

* Support for water- and ice-friendly aerosols in LBCs

* Add documentation to subroutine init_microphysics_aerosols_lbc

* Time interpolation for microphysics aerosols ICs

* Add time interpolation for microphysics aerosols to LBCs

* Aerosol time interpolation (#5)

* Add microphysics aerosol information to LBCs

* Time interpolation for microphysics aerosols ICs

* Add time interpolation for microphysics aerosols to LBCs

* Nc microphysics (#6)

* Updates for aerosol aware

* Add support for nc microphysics

* Add nc to interface

* point to develop branch of Thompson submodule

* Import nwfa and nifa into microphysics (#7)

* Add microphysics submodule makefile (#8)

* Import nwfa and nifa into microphysics

* Add makefile support for microphysics submodule

* Update location for microphysics submodule

* remove GSL_cloud_physics directory

* Point to microphysics submodule

* Point to microphysics submodule

* Remove old submodule

* Bug fix in Makefile to deal with old version of microphysics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants