Add ability to convert exo to MPAS mesh when using MOLHO for optimization#728
Conversation
…tion Treat MALI layers as repeated instances of the Albany layer when necessary, so that we can convert an exodus file to a MALI .nc file when using the MOLHO solver for the optimization.
|
@trhille thans for working on this. It is a good initial step and I'm OK if you want to merge this. |
Thanks @mperego! Glad I asked you to review :) |
Fix incorrect assumption of uniform velocity and temperature with depth when using the MOLHO solver. Now calculates these fields from upper and lower solutions using the vertical profile: T(sigma) = T_bed + (1-sigma^4) (T_top - T_bed) (same for velocity)
a16e107 to
162160d
Compare
Calculate the vertical profile of enthalpy first, then convert to temperature.
162160d to
6efb772
Compare
|
Testing the more accurate enthalpy-based calculation for the temperature profile yields results that look correct. The added check confirms correct calculation: |
mperego
left a comment
There was a problem hiding this comment.
It looks good to me.
Thanks for adding the check between the surface and basal temperatures recovered here and the ones computed by Albany!
matthewhoffman
left a comment
There was a problem hiding this comment.
Approving based on test results and review from @mperego












Treat MALI layers as repeated instances of the Albany layer when necessary, so that we can convert an exodus file to a MALI .nc file when using the single-layer MOLHO solver for the optimization.