Skip to content

Add Baja California critical blockage#113

Merged
milenaveneziani merged 2 commits intoMPAS-Dev:masterfrom
mark-petersen:add_Baja
Aug 7, 2019
Merged

Add Baja California critical blockage#113
milenaveneziani merged 2 commits intoMPAS-Dev:masterfrom
mark-petersen:add_Baja

Conversation

@mark-petersen
Copy link
Copy Markdown
Collaborator

In some low-resolution meshes, we can get a hole through Baja. This will prevent that.

@mark-petersen mark-petersen self-assigned this Aug 6, 2019
@mark-petersen
Copy link
Copy Markdown
Collaborator Author

The pictures say it all...
image
image
image

@mark-petersen
Copy link
Copy Markdown
Collaborator Author

If @xylar is traveling, perhaps @milenaveneziani can approve by visual inspection.

@xylar
Copy link
Copy Markdown
Collaborator

xylar commented Aug 6, 2019

@mark-petersen, you need to follow the procedure described here:
https://geometric-features.readthedocs.io/en/latest/adding_features.html

If you don't run write_feature_names_and_tags(), the package doesn't know about the new features and tags. As a practice, it is not encouraged for you to add features directly to geometric_data. Instead, you should split() features into geometric_data, even if you only have one feature.

@milenaveneziani
Copy link
Copy Markdown
Collaborator

Hi @mark-petersen: yes, it is very simple, just run that script and you'll get a parsed feature and a new features_and_tags.json file.

@mark-petersen
Copy link
Copy Markdown
Collaborator Author

OK, I can the second script at https://geometric-features.readthedocs.io/en/latest/adding_features.html. @xylar thanks for posting such easy instructions.

I think this is ready to merge now.

@milenaveneziani milenaveneziani merged commit ddd3548 into MPAS-Dev:master Aug 7, 2019
@milenaveneziani
Copy link
Copy Markdown
Collaborator

milenaveneziani commented Aug 7, 2019

I reran the script I used the other day to double check parsing, and all went well.
[sorry I didn't wait for approval before merging]

@mark-petersen mark-petersen deleted the add_Baja branch August 7, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants