Skip to content

Add missing 'type' key to combined features#119

Merged
xylar merged 1 commit intoMPAS-Dev:masterfrom
xylar:fix_combine_features
Oct 27, 2019
Merged

Add missing 'type' key to combined features#119
xylar merged 1 commit intoMPAS-Dev:masterfrom
xylar:fix_combine_features

Conversation

@xylar
Copy link
Copy Markdown
Collaborator

@xylar xylar commented Oct 26, 2019

Without this dictionary entry, the resulting feature is not recognized, e.g., by geojsion.io.

Without this dictionary entry, the resulting feature is not
recognized, e.g., by geojsion.io.
@xylar xylar added the bug label Oct 26, 2019
@xylar xylar requested a review from milenaveneziani October 26, 2019 12:12
@xylar xylar self-assigned this Oct 26, 2019
@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Oct 26, 2019

@milenaveneziani, I ran the following (similar to, but not identical to, what you had in your email):

./merge_features.py -c ocean -b region -n "Baffin Bay;Davis Strait" -o BaffinBaynew.geojson
./combine_features.py -f BaffinBaynew.geojson -n "Baffin Bay" -o BaffinBaynew2.geojson

Note: the merge command specifies the component and object type, which is required. Using this branch, if I then view BaffinBaynew2.geojson at geojson.io, it looks seamless to me. Could you try that out?

If you're still seeing gaps when you combine features, could you post an issue here with your steps so I can try to reproduce that problem.

@milenaveneziani
Copy link
Copy Markdown
Collaborator

yes, this works for me too @xylar. Thanks!

@xylar xylar merged commit 39f8990 into MPAS-Dev:master Oct 27, 2019
@xylar xylar deleted the fix_combine_features branch October 27, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants