Skip to content

Add GEOMETRIC_DATA_DIR environment variable#129

Merged
xylar merged 2 commits intoMPAS-Dev:masterfrom
xylar:add_geom_data_env_variable
Mar 4, 2020
Merged

Add GEOMETRIC_DATA_DIR environment variable#129
xylar merged 2 commits intoMPAS-Dev:masterfrom
xylar:add_geom_data_env_variable

Conversation

@xylar
Copy link
Copy Markdown
Collaborator

@xylar xylar commented Mar 4, 2020

This is the default location to look for geometric data if it is set. The ability to set this variable will enable optionally packaging the data with the conda package.

@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Mar 4, 2020

Hello @xylar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-03-04 04:48:48 UTC

This is the default location to look for geometric data if it is
set.  The ability to set this variable will enable optionally
packaging the data with the conda package.
@xylar xylar force-pushed the add_geom_data_env_variable branch from 35fd7b1 to 31a39f1 Compare March 4, 2020 04:38
@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Mar 4, 2020

Testing

I made a conda package with this environment variable pointing to the offline data (see conda-forge/geometric_features-feedstock#9). I used this package to run setup_ocean_region_groups.py from examples but without pointing to ./geometric_data. I ran this script in its own directory to make sure it wasn't picking up local geometric data. Everything ran as expected.

We now tell users how to install the variant of the package with
the full geometric data.
@xylar xylar merged commit e1f0c20 into MPAS-Dev:master Mar 4, 2020
@xylar xylar deleted the add_geom_data_env_variable branch March 4, 2020 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants