Skip to content

Rename Ross East --> Western Ross...#140

Merged
xylar merged 1 commit intoMPAS-Dev:masterfrom
xylar:rename_ross_parts
Jun 18, 2020
Merged

Rename Ross East --> Western Ross...#140
xylar merged 1 commit intoMPAS-Dev:masterfrom
xylar:rename_ross_parts

Conversation

@xylar
Copy link
Copy Markdown
Collaborator

@xylar xylar commented Jun 18, 2020

...and similarly Ross West --> Eastern Ross. Rignot et al. (2013) named these parts of the shelf based on which hemisphere or ice sheet they're in, but this is very confusing given that the Ross
crosses the antimeridian and thus its eastern side is in West Antarctica and its western side in East Antarctica. To be true to the local cardinal directions, we're renaming the halves in the more standard way.

closes #139

@xylar xylar added the clean up label Jun 18, 2020
@xylar xylar self-assigned this Jun 18, 2020
@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Jun 18, 2020

@stephenprice, @matthewhoffman, @darincomeau and @cbegeman, you can just review by inspection. Let me know if you have questions but the main thing is to make sure we don't get so confused about which half is the eastern vs. the western half.

For this to propagate to MPAS-Analysis, I'm going to have to make up a new name for the collection of regions (e.g iceShelvesRev2) and generate new cached mask files for our standard meshes. I'll do that once this gets merged and we have a new version of geometric_features to work with.

@xylar xylar force-pushed the rename_ross_parts branch from 588a973 to 29a2d51 Compare June 18, 2020 14:31
Copy link
Copy Markdown

@darincomeau darincomeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by inspection. Thanks for pointing this out Carolyn!

...and similarly Ross West --> Eastern Ross.  Rignot et al. (2013)
named these parts of the shelf based on which hemisphere or ice
sheet they're in, but this is very confusing given that the Ross
crosses the antimeridian and thus its eastern side is in West
Antarctica and its western side in East Antarctica.  To be true
to the local cardinal directions, we're renaming the halves in
the more standard way.
@xylar xylar force-pushed the rename_ross_parts branch from 29a2d51 to e10db4a Compare June 18, 2020 14:42
@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Jun 18, 2020

A plot of each part and the combined Ross, just to make sure nothing is messed up:

Figure_1
Figure_2
Figure_3

@cbegeman
Copy link
Copy Markdown
Collaborator

Looks great, @xylar. Thanks!

@stephenprice
Copy link
Copy Markdown
Contributor

This is fine with me. In fact, it's always driven me a little crazy that it was named like this, having finally (only after 20 yrs) trained my brain to determine east / west directions when looking at maps of Antarctica. Thanks for fixing it.

@xylar xylar removed the request for review from matthewhoffman June 18, 2020 15:39
@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Jun 18, 2020

@matthewhoffman, I'm taking you off as a reviewer because I think that's enough eyes on this. But not because I don't value your opinion. Feel free to weigh in after the merge.

@xylar xylar merged commit 2870be5 into MPAS-Dev:master Jun 18, 2020
@xylar xylar deleted the rename_ross_parts branch June 18, 2020 15:40
@matthewhoffman
Copy link
Copy Markdown
Member

@xylar , thanks - looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ross Ice Shelf melt time series labels

5 participants