-
Notifications
You must be signed in to change notification settings - Fork 25
Addition of Arctic shipping routes #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of Arctic shipping routes #143
Conversation
|
@vanroekel, @mark-petersen and @maltrud, could you take a look at these and let me know if they look good to you? |
xylar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me. Thanks @proteanplanet! I'll make a test EC60to30 mesh just to make sure things work before I merge.
|
@xylar, these files are large, 500-600k, with 4000 to 5000 points each. Thanks for testing. It will be good to see if that causes any problems, and if our python scripts can handle this in a reasonable amount of time. We have not run critical passages with this size files before. @proteanplanet what tool did you make these in? It must be an automated tool - what was your choice for the step in distance? One way to at least make the files smaller is to avoid the depth line in each point: so that the line with 0.0 does not show. Was that an option in your tool? |
|
@mark-petersen, I don't think the file size is an issue but I agree that the number of points is much higher than is likely needed even a high resolution. I hadn't noticed the 3rd coordinate. We should remove those if possible because no other features have them. |
|
The number of points is only a problem if it causes a significant slow-down in the mesh generation, so we'll see if it is an issue. |
|
Hmm, my timing suggests that this is going to have a bad impact on our nightly regression testing. Timing with these transects included: So the entire @proteanplanet, presumably an alterative would be to reduce the number of points considerably (say by a factor of 10). How hard would that be and how much might that impact the fidelity at higher res? |
@mark-petersen This is the development chain: 1) I generated the ship routes using Arctic Council transects as the initial template. My coding included evenly discretizing the tracks at 1 nautical mile (great circle) spacings. 2) From this I generated a KML file and then ingested that into https://geojson.io. The KML step is (unnecessarily) adding the altitude. @xylar Now we know that this will affect performance, I can very easily fix this development chain. 1) Reduce the transects to only the narrow passages, probably resulting in 90% saving and removing the altitude. 2) Directly code the GeoJSON to avoid step 2 entirely above. I'll regenerate. I can close this PR, and reissue another one, with short transects. |
|
Okay, sounds good. |
This adds in five shipping routes - four Northwest Passage variants and one Northern Sea Route - to the Arctic, as shown in the figure below.