Add python 3.13 #213
Merged
Add python 3.13 #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xylar
reviewed
Nov 4, 2024
xylar
approved these changes
Nov 4, 2024
Collaborator
xylar
left a comment
xylar
left a comment
There was a problem hiding this comment.
@altheaden, I went ahead and made a small fix. I don't think we're using the yaml files in ci for anything anyway but they could come up if someone wanted to build the conda package locally.
With that fix, things look great!
Collaborator
Author
|
Ok, thanks! |
Collaborator
|
I don't know why CI passed here but then gave us trouble afterward. Hopefully, #214 fixes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for python 3.13. No changes were needed for this update beyond adding the version number to
setup.pyand the CI files. I also updated the README to suggest python 3.13 as we did when we added python 3.12.