Clean-up on imports and pre-commit #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support sorted imports, version info must be moved to its own separate file and a few imports must no longer use the short-cut version.
Collaborator
Author
|
As in #221, I'm going to ignore flake8 errors for now because we don't want to deal with them all in one go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge removes and very old
__future__imports needed for python 2 support.It also makes changes needed to allow
isortto includegeometric_feature/__init__.py:version.py__main__.pyto not use shortcut in__init__.pyand to use version info fromversion.py.__init__.py.version.pyfor version info.