move fast-glob to dependencies#8
Merged
MQuy merged 2 commits intoMQuy:masterfrom Jan 27, 2019
zys-contrib:deps
Merged
Conversation
Contributor
Author
|
@MQuy Could you please take a look at this PR ? We wanna use this module as one of debDependencies and without adding other debDependencies. |
Owner
|
hi @ZYSzys, sorry for the late response, if we move |
Contributor
Author
|
I think the answer is absolutely yes. |
Owner
|
ah, so in that should we also include |
Contributor
Author
|
I think it should be yes too. It has installed |
Owner
|
can you help me to add |
Owner
|
thanks @ZYSzys 👍 |
Contributor
Author
|
@MQuy So waiting for you to bump a new version of this awesome plugin so that it can work :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was
Error: Cannot find module 'fast-glob'when using this plugin, so move the packagefast-globtodependencies.It can be reproduced in the samples directory:
yarn installinwebpack-deadcode-plugindirectory.cd samples && yarn.yarn buildin samples directory.Then error occurred as below: