Skip to content

move fast-glob to dependencies#8

Merged
MQuy merged 2 commits intoMQuy:masterfrom
zys-contrib:deps
Jan 27, 2019
Merged

move fast-glob to dependencies#8
MQuy merged 2 commits intoMQuy:masterfrom
zys-contrib:deps

Conversation

@ZYSzys
Copy link
Copy Markdown
Contributor

@ZYSzys ZYSzys commented Jan 24, 2019

There was Error: Cannot find module 'fast-glob' when using this plugin, so move the package fast-glob to dependencies.

It can be reproduced in the samples directory:

  • Don't yarn install in webpack-deadcode-plugin directory.
  • cd samples && yarn.
  • yarn build in samples directory.

Then error occurred as below:

screen shot 2019-01-24 at 10 10 17 pm

@ZYSzys
Copy link
Copy Markdown
Contributor Author

ZYSzys commented Jan 27, 2019

@MQuy Could you please take a look at this PR ? We wanna use this module as one of debDependencies and without adding other debDependencies.

@MQuy
Copy link
Copy Markdown
Owner

MQuy commented Jan 27, 2019

hi @ZYSzys, sorry for the late response, if we move fast-glob into dependencies, will it be included in your node_modules when running yarn install?

@ZYSzys
Copy link
Copy Markdown
Contributor Author

ZYSzys commented Jan 27, 2019

I think the answer is absolutely yes.

@MQuy
Copy link
Copy Markdown
Owner

MQuy commented Jan 27, 2019

ah, so in that should we also include chalk?

@ZYSzys
Copy link
Copy Markdown
Contributor Author

ZYSzys commented Jan 27, 2019

I think it should be yes too.

It has installed chalk because of your samples/yarn.lock so there isn't error said chalk missed.

@MQuy
Copy link
Copy Markdown
Owner

MQuy commented Jan 27, 2019

can you help me to add chalk, I think it is better if we can do it in one pr 🤔

@MQuy
Copy link
Copy Markdown
Owner

MQuy commented Jan 27, 2019

thanks @ZYSzys 👍

@MQuy MQuy merged commit d654f9e into MQuy:master Jan 27, 2019
@ZYSzys
Copy link
Copy Markdown
Contributor Author

ZYSzys commented Jan 27, 2019

@MQuy So waiting for you to bump a new version of this awesome plugin so that it can work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants