Skip to content

Add affine matrix to phantom mz#176

Merged
SWeinmueller merged 2 commits into
AddAffineMatrixToPhantomfrom
AddAffineMatrixToPhantom_mz
Jun 25, 2026
Merged

Add affine matrix to phantom mz#176
SWeinmueller merged 2 commits into
AddAffineMatrixToPhantomfrom
AddAffineMatrixToPhantom_mz

Conversation

@mzaiss

@mzaiss mzaiss commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

i dont know if this is planned, but this makes the legacy interpolate and slices compatible with the new affine standard.

two problems:

  1. interpolate created some Nans with the new affine reslice. thsi si now caught
  2. interpolate must alter the affine, otherwise the phantom size implicitly changes. which is also done here

I also updated the obj size when slices is used, this wasn't done yet also without affine, but should be done.

@mzaiss mzaiss requested a review from SWeinmueller June 24, 2026 21:25

@SWeinmueller SWeinmueller left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine and everything works for me.
In the future, interpolate and slice function could be depricated and/or _resample_nifit function could be used instead.

@SWeinmueller SWeinmueller merged commit db9d681 into AddAffineMatrixToPhantom Jun 25, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants