DungeonMission Value1 & Value2 type fix

[Zintixx]

Summary by CodeRabbit

• Chores
  • Updated package to version 2.4.9 with internal improvements to data handling and serialization.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR updates the DungeonMission XML data model by converting numeric field types (value1 from float[], value2 from int) to string representations, then increments the package version from 2.4.8 to 2.4.9 to reflect the release.

Changes

DungeonMission Field Type Update and Release

Layer / File(s)	Summary
Data Model Update Maple2.File.Parser/Xml/Table/DungeonMission.cs	Fields value1 and value2 are converted from numeric types (float[] and int) to string, each defaulting to string.Empty.
Version Release Maple2.File.Parser/Maple2.File.Parser.csproj	Package version is updated from 2.4.8 to 2.4.9.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

• AngeloTadeucci

Poem

🐰 A hop, a skip, the types align,
From numbers bold to strings so fine,
Version bumps with careful care,
DungeonMission gets an upgrade rare! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: updating value1 and value2 field types in DungeonMission from numeric types to strings.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Maple2.File.Parser/Maple2.File.Parser.csproj`:
- Line 16: The project file currently sets <PackageVersion> to 2.4.9 which is a
patch bump even though the PR changes public member types on DungeonMission (a
breaking change); update the <PackageVersion> element value from 2.4.9 to a
major-breaking version (e.g. 3.0.0) so the package is published with a major
version bump reflecting the API break.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 69fa104d-46a6-419b-937c-af469248ca5f

📥 Commits

Reviewing files that changed from the base of the PR and between 7826e96 and e873086.

📒 Files selected for processing (2)

• Maple2.File.Parser/Maple2.File.Parser.csproj
• Maple2.File.Parser/Xml/Table/DungeonMission.cs

[coderabbitai]

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Use a breaking-version bump for this release.

Line 16 sets a patch release, but this PR changes public member types in DungeonMission, which is a breaking contract change for consumers. Please bump to a major version before publishing.

Suggested change

-        <PackageVersion>2.4.9</PackageVersion>
+        <PackageVersion>3.0.0</PackageVersion>

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	<PackageVersion>2.4.9</PackageVersion>
	<PackageVersion>3.0.0</PackageVersion>

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Maple2.File.Parser/Maple2.File.Parser.csproj` at line 16, The project file
currently sets <PackageVersion> to 2.4.9 which is a patch bump even though the
PR changes public member types on DungeonMission (a breaking change); update the
<PackageVersion> element value from 2.4.9 to a major-breaking version (e.g.
3.0.0) so the package is published with a major version bump reflecting the API
break.