Parse Npc Scale Factor By Level Table & Job Select

[Zintixx]

Summary by CodeRabbit

• New Features

  • Parse NPC stat factors by level.
  • Parse character creation selection data for character setup.

• Updates

  • NPC player-count data now includes an additional HP value attribute.

• Tests

  • Added tests covering the new parsers.

• Chores

  • Updated package version to 2.4.12.

[coderabbitai]

Warning

Rate limit exceeded

@Zintixx has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 57 minutes and 4 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b5636b78-8c57-4ec6-89b9-56fe6ccfacd7

📥 Commits

Reviewing files that changed from the base of the PR and between d99b477 and 44c462b.

📒 Files selected for processing (1)

• Maple2.File.Parser/Maple2.File.Parser.csproj

📝 Walkthrough

Walkthrough

Adds XML models and parser methods for npcStatFactorByLevel and charactercreateselect, a small model attribute (hpValue), corresponding tests, and increments package version to 2.4.12.

Changes

Server and Table Parsing Additions

Layer / File(s)	Summary
XML data models Maple2.File.Parser/Xml/Table/Server/NpcStatFactorByLevel.cs, Maple2.File.Parser/Xml/Table/Server/NpcStatFactorByPlayerCount.cs, Maple2.File.Parser/Xml/Table/CharacterCreateSelect.cs	Adds NpcStatFactorByLevelRoot and NpcStatFactorByLevel models for npcStatFactorByLevel.xml, adds hpValue attribute to NpcStatFactorByPlayerCount, and introduces CharacterCreateSelect model types with localized groups and M2dArray fields.
ServerTableParser implementation Maple2.File.Parser/ServerTableParser.cs	Declares and initializes npcStatFactorByLevelSerializer, refactors ParseNpcStatFactorByPlayerCount yield syntax, and adds ParseNpcStatFactorByLevel() returning level-factor entries.
TableParser characterCreateSelect support Maple2.File.Parser/TableParser.cs	Adds characterCreateSelectSerializer, initializes it, and adds ParseCharacterCreateSelect() that deserializes table/charactercreateselect.xml and yields (name, group) pairs.
Tests and package version Maple2.File.Tests/ServerTableParserTest.cs, Maple2.File.Tests/TableParserTest.cs, Maple2.File.Parser/Maple2.File.Parser.csproj	Adds TestNpcStatFactorByLevel() and TestCharacterCreateSelect() that iterate parser outputs, and updates PackageVersion to 2.4.12.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

• AngeloTadeucci

Poem

🐰 I hop through XML rows with glee,
Level factors and choices I see,
New serializers hum their tune,
Tests tiptoe under the moon,
Version bumped — a tiny spree!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately references the main changes: adding support for parsing the NpcStatFactorByLevel table and CharacterCreateSelect (job select). Both features are prominently featured across multiple modified files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}