Fix: daily reset

[AngeloTadeucci]

Summary by CodeRabbit

• New Features

  • Improved the daily reset functionality to ensure server state changes are accurately recorded in the database.

• Bug Fixes

  • Enhanced tracking of modifications to server information, ensuring that updates reflect the correct last modified timestamp.

[coderabbitai]

Walkthrough

The modification includes an update to the DailyReset method in the GameStorage.ServerInfo class. A line has been added to ensure that the serverInfo object is updated in the database context before saving changes, facilitating accurate tracking of modifications, particularly the LastModified timestamp.

Changes

Files	Change Summary
Maple2.Database/.../GameStorage.ServerInfo.cs	Added Context.Update(serverInfo); to DailyReset method to ensure serverInfo is tracked in the database.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant ServerInfo
    participant DatabaseContext
    
    Client->>ServerInfo: Calls DailyReset()
    ServerInfo->>DatabaseContext: Update serverInfo
    DatabaseContext->>DatabaseContext: Track changes
    DatabaseContext->>ServerInfo: Save changes

Loading

Poem

🐰 In the realm of code where bunnies play,
We’ve added a twist to brighten the day!
The serverInfo now gets its due,
With updates tracked, it’s fresh and new.
Let’s hop along, with joy we’ll sing,
For every change, new wonders they bring! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b46814a and 6b72f6e.

Files selected for processing (1)

• Maple2.Database/Storage/Game/GameStorage.ServerInfo.cs (1 hunks)

Additional comments not posted (1)

Maple2.Database/Storage/Game/GameStorage.ServerInfo.cs (1)

28-28: LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to DailyReset are consistent with the new behavior.

Run the following script to verify the function usage:

Verification successful

---

Function usage of DailyReset is consistent.

The DailyReset method is used appropriately across the codebase, ensuring that daily resets are handled correctly in various components. The addition of Context.Update(serverInfo); is correctly integrated and aligns with the intended functionality.

• Maple2.Server.World/WorldServer.cs: Used within StartDailyReset and ScheduleDailyReset.
• Maple2.Server.Game/Session/GameSession.cs: Implemented as a public method.
• Maple2.Server.Game/Service/ChannelService.GameReset.cs: Invoked within a method.
• Maple2.Server.Game/GameServer.cs: Implemented as a public method.
• Maple2.Database/Storage/Game/GameStorage.ServerInfo.cs: Implemented as a public method with thread safety.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `DailyReset` to ensure consistency.

# Test: Search for the function usage. Expect: No inconsistencies in the function calls.
rg --type cs -A 5 $'DailyReset'

Length of output: 6048