docs(deploy): use mskanban.msk-scripts.de as the example/default domain#55
Merged
Conversation
Picks up the actual production hostname (mskanban.msk-scripts.de) in three spots that previously used kanban.msk-scripts.de as a placeholder: - .github/workflows/deploy.yml: environment.url + DEPLOY_HOST comment - docs/deployment/auto-deploy.md: all four mentions (secrets table, ssh-keyscan command, certbot invocation, lockdown test snippet) No code path change — these are documentation/UI strings only. The workflow itself reads the host from the DEPLOY_HOST secret and so isn't affected by the change to environment.url. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Musiker15 <info@musiker15.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quick follow-up to #54 — the domain fix that should have been part of that merge but ended up on the now-deleted
feat/auto-deploybranch as a separate commit, after the PR was already squash-merged.Replaces the placeholder
kanban.msk-scripts.dewith the actual production hostnamemskanban.msk-scripts.dein:.github/workflows/deploy.yml—environment.url+ the DEPLOY_HOST commentdocs/deployment/auto-deploy.md— secrets-table example, ssh-keyscan command, certbot invocation, lockdown-test snippetWhat's NOT affected by this
The workflow uses
secrets.DEPLOY_HOSTfor the actual SSH target — it doesn't readenvironment.url. So the auto-deploy already works correctly as long as theDEPLOY_HOSTsecret is set to the right hostname (which it will be). This PR is documentation hygiene + correct env-URL display in the GitHub Environments UI, not a functional change.Test plan
git diffshows only string replacementskanban→mskanbanin two files (6 lines total)productionshowshttps://mskanban.msk-scripts.de/🤖 Generated with Claude Code