feat: add getItemsByFunction and getItemsByFunctionAtSlot#323
Merged
LordMidas merged 4 commits intodevelopmentfrom Apr 13, 2024
Merged
feat: add getItemsByFunction and getItemsByFunctionAtSlot#323LordMidas merged 4 commits intodevelopmentfrom
LordMidas merged 4 commits intodevelopmentfrom
Conversation
TaroEld
reviewed
Oct 22, 2023
LordMidas
force-pushed
the
feat-item-getByFunction
branch
from
9be46f6 to
6b681aa
Compare
LordMidas
changed the base branch from
development
to
feat-port-to-modern-hooks
TaroEld
requested changes
Feb 27, 2024
TaroEld
approved these changes
Feb 27, 2024
TaroEld
approved these changes
Feb 27, 2024
Enduriel
approved these changes
Feb 27, 2024
Member
Enduriel
left a comment
Enduriel
left a comment
There was a problem hiding this comment.
Big fan of the new structure
LordMidas
force-pushed
the
feat-port-to-modern-hooks
branch
from
de55d30 to
983c30b
Compare
LordMidas
force-pushed
the
feat-item-getByFunction
branch
from
f3deb20 to
e84c794
Compare
LordMidas
added a commit
that referenced
this pull request
May 10, 2024
)" This reverts commit b3b8ab6. Because the functionality added by these functions can be achieved natively by using `.filter` on vanilla `getAllItems` and `getAllItemsAtSlot` functions of item_container.
LordMidas
added a commit
that referenced
this pull request
May 21, 2024
)" This reverts commit b3b8ab6. Because the functionality added by these functions can be achieved natively by using `.filter` on vanilla `getAllItems` and `getAllItemsAtSlot` functions of item_container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged AFTER #316 (port to modern hooks)