Skip to content

Adjust iOS browser chrome colors #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MSicc merged 1 commit into from
Mar 8, 2026
Merged

Adjust iOS browser chrome colors #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion assets/css/site.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@

html {
scroll-behavior: smooth;
background: linear-gradient(180deg, #f5f8fb 0%, #ebf1f7 100%);
background:
linear-gradient(180deg, #0f172a 0, #0f172a 8rem, #f5f8fb 8rem, #ebf1f7 100%);
Copy link

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 8rem cutoff is duplicated in multiple gradients. Consider extracting it into a single SCSS variable (or CSS custom property) so the “top chrome height” can be adjusted in one place and stays consistent across html and body.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gradient stop 0 is valid, but using an explicit unit (e.g., 0%) improves readability/consistency with the other stops (8rem, 100%) and reduces ambiguity for future edits.

Suggested change
linear-gradient(180deg, #0f172a 0, #0f172a 8rem, #f5f8fb 8rem, #ebf1f7 100%);
linear-gradient(180deg, #0f172a 0%, #0f172a 8rem, #f5f8fb 8rem, #ebf1f7 100%);

Copilot uses AI. Check for mistakes.
}

@media (prefers-reduced-motion: reduce) {
Expand All @@ -48,6 +49,7 @@ body {
font-family: "Source Sans 3", sans-serif;
color: var(--text);
background:
linear-gradient(180deg, rgba(15, 23, 42, 1) 0, rgba(15, 23, 42, 1) 8rem, rgba(245, 248, 251, 0) 8rem),
Copy link

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 8rem cutoff is duplicated in multiple gradients. Consider extracting it into a single SCSS variable (or CSS custom property) so the “top chrome height” can be adjusted in one place and stays consistent across html and body.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gradient stop 0 is valid, but using an explicit unit (e.g., 0%) improves readability/consistency with the other stops (8rem, 100%) and reduces ambiguity for future edits.

Suggested change
linear-gradient(180deg, rgba(15, 23, 42, 1) 0, rgba(15, 23, 42, 1) 8rem, rgba(245, 248, 251, 0) 8rem),
linear-gradient(180deg, rgba(15, 23, 42, 1) 0%, rgba(15, 23, 42, 1) 8rem, rgba(245, 248, 251, 0) 8rem),

Copilot uses AI. Check for mistakes.
radial-gradient(circle at top left, rgba(103, 146, 196, 0.18), transparent 30%),
linear-gradient(180deg, #f5f8fb 0%, #ebf1f7 100%);
}
Expand Down
6 changes: 3 additions & 3 deletions assets/img/favicon/site.webmanifest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"purpose": "maskable"
}
],
"theme_color": "#ffffff",
"background_color": "#ffffff",
"theme_color": "#0f172a",
Copy link

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theme_color in site.webmanifest typically does not affect iOS Safari’s browser UI (unless the site is installed as a web app). If the PR goal is “iOS browser chrome colors” in Safari, add/update a corresponding <meta name="theme-color" content="#0f172a"> (and, if applicable, apple-mobile-web-app-status-bar-style) in the site’s HTML head/layout so iOS Safari picks it up.

Suggested change
"theme_color": "#0f172a",

Copilot uses AI. Check for mistakes.
"background_color": "#ebf1f7",
"display": "standalone"
}
}
Loading