Skip to content

Added intersection metric (#95)#148

Merged
blondered merged 12 commits intoMTSWebServices:mainfrom
azatnv:feature/intersecton_metric
May 31, 2024
Merged

Added intersection metric (#95)#148
blondered merged 12 commits intoMTSWebServices:mainfrom
azatnv:feature/intersecton_metric

Conversation

@azatnv
Copy link
Copy Markdown
Contributor

@azatnv azatnv commented May 21, 2024

Description

  • Added intersection metric.

Closes #95

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

  • Have you read the contribution guide?
  • Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
  • Does your change require any new tests?
  • Have you updated the changelog file?

blondered
blondered requested changes May 22, 2024
View reviewed changes
Comment thread rectools/metrics/intersection.py Outdated
Comment thread rectools/metrics/intersection.py Outdated
Comment thread rectools/metrics/intersection.py Outdated
Comment thread CHANGELOG.md Outdated
Comment thread rectools/metrics/intersection.py Outdated
Comment thread tests/metrics/test_intersection.py
@azatnv
Copy link
Copy Markdown
Contributor Author

azatnv commented May 22, 2024 •
edited
Loading

@blondered I have addressed all the comments

blondered
blondered requested changes May 23, 2024
View reviewed changes
Comment thread rectools/metrics/scoring.py
blondered
blondered reviewed May 23, 2024
View reviewed changes
Comment thread rectools/metrics/intersection.py
blondered
blondered requested changes May 27, 2024
View reviewed changes
Comment thread rectools/model_selection/cross_validate.py Outdated
Comment thread rectools/model_selection/cross_validate.py
Comment thread rectools/model_selection/cross_validate.py Outdated
Comment thread rectools/model_selection/cross_validate.py Outdated
blondered
blondered requested changes May 27, 2024
View reviewed changes
Comment thread rectools/metrics/scoring.py Outdated
blondered
blondered requested changes May 29, 2024
View reviewed changes
Comment thread tests/model_selection/test_cross_validate.py
Comment thread rectools/model_selection/cross_validate.py Outdated
blondered
blondered reviewed May 29, 2024
View reviewed changes
Comment thread rectools/model_selection/cross_validate.py Outdated
Comment thread rectools/model_selection/cross_validate.py Outdated
Comment thread rectools/model_selection/cross_validate.py Outdated
blondered
blondered reviewed May 30, 2024
View reviewed changes
Comment thread rectools/metrics/intersection.py Outdated
blondered
blondered reviewed May 30, 2024
View reviewed changes
Comment thread rectools/metrics/intersection.py Outdated
@blondered blondered merged commit be42c82 into MTSWebServices:main May 31, 2024
blondered pushed a commit that referenced this pull request Sep 23, 2024
@azatnv
Feature/Intersection metric (#148)
acc93a3 
Added intersection metric
Closes #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blondered blondered blondered approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Recommendations intersection metric

2 participants

@azatnv @blondered