Skip to content

Feature/metricsapp metainfo#154

Merged
feldlime merged 49 commits intoMTSWebServices:mainfrom
Gooogr:feature/metricsapp_metainfo
Jul 26, 2024
Merged

Feature/metricsapp metainfo#154
feldlime merged 49 commits intoMTSWebServices:mainfrom
Gooogr:feature/metricsapp_metainfo

Conversation

@Gooogr
Copy link
Copy Markdown
Contributor

@Gooogr Gooogr commented Jun 19, 2024

Description

Closes #150: add support of scatter plot colors maps based on any model meta-info.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

  • Have you read the contribution guide?
  • Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
  • Does your change require any new tests?
  • Have you updated the changelog file?

@Gooogr Gooogr marked this pull request as draft June 19, 2024 22:49
@Gooogr
Copy link
Copy Markdown
Contributor Author

Gooogr commented Jun 19, 2024

TODO:

  • Update docstring with metadata example
  • Expand tests
  • Update .ipynb example (cross-validation)
  • Update changelog

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b3992e) to head (2d4546c).
Report is 68 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #154     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           45        55     +10     
  Lines         2242      3361   +1119     
===========================================
+ Hits          2242      3361   +1119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gooogr
Copy link
Copy Markdown
Contributor Author

Gooogr commented Jun 20, 2024

TODO:

  • Improve test coverage for codecov

Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread examples/MetricApp test.ipynb Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread CHANGELOG.md Outdated
Comment thread rectools/visuals/metrics_app.py
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Gooogr and others added 12 commits July 23, 2024 17:11
Co-authored-by: Emiliy Feldman <feldlime@yandex.ru>
Co-authored-by: Emiliy Feldman <feldlime@yandex.ru>
Co-authored-by: Emiliy Feldman <feldlime@yandex.ru>
Co-authored-by: Emiliy Feldman <feldlime@yandex.ru>
Co-authored-by: Emiliy Feldman <feldlime@yandex.ru>
Co-authored-by: Emiliy Feldman <feldlime@yandex.ru>
Co-authored-by: Emiliy Feldman <feldlime@yandex.ru>
Co-authored-by: Emiliy Feldman <feldlime@yandex.ru>
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
@Gooogr Gooogr force-pushed the feature/metricsapp_metainfo branch from 14d9ce8 to 17ab300 Compare July 24, 2024 06:49
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py Outdated
Comment thread rectools/visuals/metrics_app.py
@feldlime feldlime merged commit 8f9956a into MTSWebServices:main Jul 26, 2024
blondered pushed a commit that referenced this pull request Sep 23, 2024
Closes #150: add
support of scatter plot colors maps based on any model meta-info.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add model_meta processing to MetricsApp for labels colouring

3 participants